D23730: Add new protocol for 7z archives

This revision was automatically updated to reflect the committed changes. Closed by commit R320:f3e66c240d1e: Add new protocol for 7z archives (authored by nhiga, committed by ngraham). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23730?vs=65416&id=70982

D23730: Add new protocol for 7z archives

ngraham accepted this revision. ngraham added reviewers: dfaure, pino, cfeck. ngraham added a comment. Yeah, I agree that the name is not 100% ideal, but honestly that's an implementation detail that shouldn't block this. The code and functionality look sound! REPOSITORY R320 KIO Extras R

D23730: Add new protocol for 7z archives

ngraham edited the summary of this revision. ngraham added dependencies: D23780: Add new protocol for 7z archives, D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23730 To: nhiga, meven Cc

D23730: Add new protocol for 7z archives

nhiga edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23730 To: nhiga, meven Cc: ltoscano, meven, ngraham, kfm-devel, kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, m

D23730: Add new protocol for 7z archives

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. `7zip:/` is in fact not correct because this would make the url scheme 7zip, but a url scheme must begin with a letter . That's too bad URL aren't not more flexible. REPOSITORY R320 KIO E

D23730: Add new protocol for 7z archives

ngraham added a comment. In D23730#526045 , @nhiga wrote: > @meven > > There is a weird bug if I name the protocol as "7z" or "7zip": > > 1. If I double click on the 7z file, Dolphin gives the "invalid protocol" error. > 2. If I try to

D23730: Add new protocol for 7z archives

nhiga added a comment. @meven There is a weird bug if I name the protocol as "7z" or "7zip": 1. If I double click on the 7z file, Dolphin gives the "invalid protocol" error. 2. If I try to manually enter the URL in Dolphin, i.e. `7z:/tmp/bar.7z` or `7zip:/tmp/bar.7z`, it does not

D23730: Add new protocol for 7z archives

meven requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23730 To: nhiga, meven Cc: ltoscano, meven, ngraham, kfm-devel, kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampal

D23730: Add new protocol for 7z archives

meven added a comment. In D23730#526024 , @ltoscano wrote: > Does it work when the older KIO is installed? Yes, I have tested it. INLINE COMMENTS > sevenz.protocol:3 > +exec=kf5/kio/archive > +protocol=sevenz > +archiveMimetype=applicati

D23730: Add new protocol for 7z archives

ltoscano added a comment. Does it work when the older KIO is installed? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23730 To: nhiga, meven Cc: ltoscano, meven, ngraham, kfm-devel, kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde

D23730: Add new protocol for 7z archives

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. In D23730#526010 , @ngraham wrote: > Probably best to submit the KIO patch first. D23490 has been ac

D23730: Add new protocol for 7z archives

ngraham added a comment. Probably best to submit the KIO patch first. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23730 To: nhiga Cc: ngraham, kfm-devel, kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew

D23730: Add new protocol for 7z archives

nhiga added a comment. Notes: 1. This patch requires D23490 and the following KIO patch: diff --git a/src/filewidgets/kurlnavigator.cpp b/src/filewidgets/kurlnavigator.cpp index 80aa975..5a6c720 100644 --- a/src/filewidgets/kurlnavigato

D23730: Add new protocol for 7z archives

nhiga created this revision. nhiga added a project: Frameworks. Herald added a project: Dolphin. Herald added a subscriber: kfm-devel. nhiga requested review of this revision. REVISION SUMMARY This patch adds a new protocol, sevenz, for 7z archives by utilizing K7Zip. Previously, users have to