D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau retitled this revision from "RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API" to "Add ECMGenerateExportHeaders, for improved handling of deprecated API". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added reviewers: Frameworks, Build System. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau, #frameworks, #build_system Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh,

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

dfaure added a comment. In D23789#541134 , @kossebau wrote: > In D23789#540033 , @dfaure wrote: > > > I found confirmation in cmake's Tests/RunCMake/GenerateExportHeader/reference/ > > > Not su

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 67523. kossebau added a comment. - add missing group defaulting for warning settings, got lost in rebase before REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23789?vs=67324&id=67523 BRANCH addgenerateex

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. So, given the lack of further change proposals or objections, I would proceed to push this in the next days (Thurday evening or Friday morning), to have 3 weeks of pre-5.64 real world testing by CI and people running from git master. See also https://mail.kde.org/

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

dfaure added inline comments. INLINE COMMENTS > ECMGenerateExportHeader.cmake:269 > +# cannot be used to reactivate the declaration, and ``Foo::doWhat`` will not > +# have been built into the library binary. > +# Really? Isn't doWhat excluded only if EXCLUDE_DEPRECATED_BEFORE_AND_AT is set to 5

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 67554. kossebau marked an inline comment as done. kossebau added a comment. - update to David's findings in the docs REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23789?vs=67523&id=67554 BRANCH addgener

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau marked 2 inline comments as done. kossebau added inline comments. INLINE COMMENTS > dfaure wrote in ECMGenerateExportHeader.cmake:269 > Really? Isn't doWhat excluded only if EXCLUDE_DEPRECATED_BEFORE_AND_AT is set > to 5.12.0? > With 5.0.0 it's still available, no? > > I'm also surpris

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 67584. kossebau added a comment. improve documentation, especially about the generated C++ macros REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23789?vs=67554&id=67584 BRANCH addgenerateexportheader RE