D23894: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()

dfaure created this revision. dfaure added reviewers: mart, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY I'm assuming we don't want to rename the property just yet, for SC? Are th

D23894: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()

aacid added a comment. maybe add the angleX property so we can tell people to move from angle to angleX and in KF6 we can remove angle and all is nice? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23894 To: dfaure, mart, davidedmundson Cc: aacid, kde-framewo

D23894: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()

dfaure updated this revision to Diff 65984. dfaure added a comment. Add deltaY property (good idea). Not that QML code will get any warning for using a deprecated property though... REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23894?vs=65899&id

D23894: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()

aacid added a comment. In D23894#530619 , @dfaure wrote: > Not that QML code will get any warning for using a deprecated property though... Maybe something we can suggest for KF6 to add a DEPRECATED to properties? Anyhow this looks g

D23894: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Kf6 ideally we drop this whole class and the new event handlers will do everything properly without these hacks...let's see. REPOSITORY R296 KDeclarative BRANCH qwheele

D23894: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()

dfaure closed this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23894 To: dfaure, mart, davidedmundson Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns