D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

ngraham added a comment. Thanks a bunch! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23989 To: mdlubakowski, dfaure, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

dfaure added a comment. Done, I released a KIO 5.62.1 and informed packagers. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23989 To: mdlubakowski, dfaure, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

mdlubakowski added a comment. In D23989#532692 , @ngraham wrote: > I wonder if this should maybe be backported to 5.62, since it represents a regression introduced in that release. Thoughts? I would say yes, since I imagine this may be

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

This revision was automatically updated to reflect the committed changes. Closed by commit R241:fdb10a52bfe8: Fixed interaction with DOS/Windows executables in KRun::runUrl (authored by mdlubakowski, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

ngraham added a comment. I wonder if this should maybe be backported to 5.62, since it represents a regression introduced in that release. Thoughts? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23989 To: mdlubakowski, dfaure, #frameworks Cc: ngraham,

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH exe-file-handling REVISION DETAIL https://phabricator.kde.org/D23989 To: mdlubakowski, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

mdlubakowski marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23989 To: mdlubakowski, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

mdlubakowski marked 3 inline comments as done. mdlubakowski added inline comments. INLINE COMMENTS > dfaure wrote in krun.cpp:390 > Can you split this into two "else if" conditions? It will be more readable > (both the condition, and the comment). This only duplicates a trivial "canRun > =

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

mdlubakowski updated this revision to Diff 66226. mdlubakowski added a comment. - Incorporated feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23989?vs=66215=66226 BRANCH exe-file-handling REVISION DETAIL https://phabricator.kde.org/D23989

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Thanks for the quick fix. INLINE COMMENTS > krun.cpp:366 > +// On Windows, run all executables normally > +bool runWindowsExecutable = true; >

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

mdlubakowski retitled this revision from "Fixed DOS/Windows executable handling by KRun" to "Fixed interaction with DOS/Windows executables in KRun::runUrl". mdlubakowski edited the summary of this revision. mdlubakowski added reviewers: dfaure, Frameworks. REPOSITORY R241 KIO REVISION DETAIL