romangg added a comment.
By the way I guess the reason why only the
`PrimarySelectionOfferV1InterfaceVersion` is there without the patch is that
the other interfaces are created through the manager on request of the client
while the offer is created server-side and then sent through an event
romangg added a comment.
Header output with the patch:
#ifndef KWAYLAND_SERVER_WP_PRIMARY_SELECTION_UNSTABLE_V1_H
#define KWAYLAND_SERVER_WP_PRIMARY_SELECTION_UNSTABLE_V1_H
#include "global.h"
#include "resource.h"
#include
namespace KWayland
{
gladhorn marked an inline comment as done.
gladhorn added inline comments.
INLINE COMMENTS
> zzag wrote in generator.cpp:431
> Is it correct thogugh? Can you provide some test input so it's easier to see
> the problem?
run kwaylandScanner on
/usr/share/wayland-protocols/unstable/primary-select
gladhorn added a comment.
The unstable primary selection v1 protocol produces code that doesn't
compile, after this change it does compile - since it expects the version enums
for three classes, but only the first one is actually written into the file.
REPOSITORY
R127 KWayland
REVISION DE
zzag added a comment.
FYI, https://phabricator.kde.org/D22362#493722
INLINE COMMENTS
> generator.cpp:431
> auto it = std::find_if(m_interfaces.constBegin(),
> m_interfaces.constEnd(), [] (const Interface &i) { return i.isGlobal(); });
> -if (it != m_interfaces.constE
gladhorn created this revision.
gladhorn added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gladhorn requested review of this revision.
REVISION SUMMARY
Otherwise it only creates the enum for the first class encountered.
REPOSITORY
R12
