apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
We were not adjusting the property name to the getter letter-casing.
TEST PLAN
See added
aacid added a comment.
Doesn't this create any change on the other test13 files?
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D24010
To: apol, #frameworks
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
apol updated this revision to Diff 66271.
apol added a comment.
Also make the property lowercase
QML doesn't like properties that start uppercase
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24010?vs=66270&id=66271
BRANCH
master
REVISION DETAIL
ngraham added a dependent revision: D5961: Adoption of KUserFeedback for
Discover.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D24010
To: apol, #frameworks
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
ngraham added a comment.
+1, Works for me
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D24010
To: apol, #frameworks
Cc: ngraham, aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
apol updated this revision to Diff 67204.
apol added a comment.
Update test, it seems like tests aren't comparing with .ref now :(
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24010?vs=66271&id=67204
BRANCH
master
REVISION DETAIL
https://phabricator
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R237 KConfig
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D24010
To: apol, #frameworks, davidedmundson
Cc: ngraham, aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:a23acd2f1535: Fix generating properties that start with
an uppercase letter (authored by apol).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24010?vs=67204&id=672