fabianr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
fabianr requested review of this revision.
REVISION SUMMARY
Added a grunt task for generating (web)fonts out of the breeze action svg
icons
REPOSITORY
R266 Breeze Icons
BRANCH
fabianr added a reviewer: ndavis.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D24015
To: fabianr, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
ognarb added inline comments.
INLINE COMMENTS
> Gruntfile.js:13
> +types: 'eot,woff2,ttf,svg',
> +optimize: false
> +}
why not true?
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D24
fabianr added inline comments.
INLINE COMMENTS
> ognarb wrote in Gruntfile.js:13
> why not true?
From
https://www.npmjs.com/package/grunt-webfont
> optimize
>
> Type: boolean Default: true
>
> If false the SVGO optimization will not be used. This is useful in cases
> where the optimizer will
ognarb accepted this revision.
ognarb added a comment.
This revision is now accepted and ready to land.
LGTM
REPOSITORY
R266 Breeze Icons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D24015
To: fabianr, ndavis, ognarb
Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, mic
ndavis accepted this revision.
REPOSITORY
R266 Breeze Icons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D24015
To: fabianr, ndavis, ognarb
Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
fabianr closed this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D24015
To: fabianr, ndavis, ognarb
Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
