D24091: Move "Full Screen Mode" item from Settings menu to View menu

This revision was automatically updated to reflect the committed changes. Closed by commit R263:93455f78d78d: Move Full Screen Mode item from Settings menu to View menu (authored by ngraham). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24091?vs=66541=66554

D24091: Move "Full Screen Mode" item from Settings menu to View menu

ngraham edited the test plan for this revision. REPOSITORY R263 KXmlGui BRANCH move_fullscreen_to_view_menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D24091 To: ngraham, #vdg, #frameworks, cfeck, ndavis Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24091: Move "Full Screen Mode" item from Settings menu to View menu

ngraham updated this revision to Diff 66541. ngraham added a comment. Add safe extra separator REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24091?vs=66484=66541 BRANCH move_fullscreen_to_view_menu (branched from master) REVISION DETAIL

D24091: Move "Full Screen Mode" item from Settings menu to View menu

ngraham added a comment. Oh perfect, then this can land as-is. Thanks! REPOSITORY R263 KXmlGui BRANCH move_fullscreen_to_view_menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D24091 To: ngraham, #vdg, #frameworks, cfeck, ndavis Cc: dfaure, kde-frameworks-devel,

D24091: Move "Full Screen Mode" item from Settings menu to View menu

dfaure added a comment. You can never end up with double separators, QMenu takes care of that. REPOSITORY R263 KXmlGui BRANCH move_fullscreen_to_view_menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D24091 To: ngraham, #vdg, #frameworks, cfeck, ndavis Cc:

D24091: Move "Full Screen Mode" item from Settings menu to View menu

ngraham added a comment. @cfeck can clarify, but I believe it specifies the location of locally-added actions that come from the app itself. It would be empty if the app has a View menu but doesn't add any of its own actions (which seems unlikely, but is theoretically possible).

D24091: Move "Full Screen Mode" item from Settings menu to View menu

ndavis added a comment. In D24091#534786 , @ngraham wrote: > Do you think I should always have a separator above the Full Screen menu item? This should generally work fine, but it means that in case the `MergeLocal` content is empty, there will

D24091: Move "Full Screen Mode" item from Settings menu to View menu

ngraham added a comment. Do you think I should always have a separator above the Full Screen menu item? This should generally work fine, but it means that in case the `MergeLocal` content is empty, there will be two separators in a row. I don't know how likely this is to ever happen, but it

D24091: Move "Full Screen Mode" item from Settings menu to View menu

ngraham edited the summary of this revision. REPOSITORY R263 KXmlGui BRANCH move_fullscreen_to_view_menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D24091 To: ngraham, #vdg, #frameworks, cfeck, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24091: Move "Full Screen Mode" item from Settings menu to View menu

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH move_fullscreen_to_view_menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D24091 To: ngraham, #vdg, #frameworks, cfeck, ndavis Cc: kde-frameworks-devel,

D24091: Move "Full Screen Mode" item from Settings menu to View menu

ngraham created this revision. ngraham added reviewers: VDG, Frameworks, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This is a pretty longstanding feature request and all the HIG and VDG