This revision was automatically updated to reflect the committed changes.
Closed by commit R216:d6b1e02ad4da: Fix skipOffset with dynamic RegExpr
(authored by jpoelen).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D24179?vs=66788=66928#toc
REPOSITORY
R216 Syntax Highlighting
CHANGES
cullmann accepted this revision.
REPOSITORY
R216 Syntax Highlighting
BRANCH
d399388 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D24179
To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson,
jpoelen updated this revision to Diff 66788.
jpoelen added a comment.
- add a comment
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24179?vs=66724=66788
BRANCH
d399388 (branched from master)
REVISION DETAIL
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Seems reasonable, thanks
I think it would be nice to have a comment added to the
612
613 /**
613 /**
614* no match
614
jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.
REVISION SUMMARY
The pattern used depends on the previous contexts so skipOffset cannot be
computed
