D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION DETAIL https://phabr

D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, mic

D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread Nathaniel Graham
ngraham added a comment. Lol "squiggle." I can't think of anything better either. Maybe the stroke would look better with butt-style ends? Like this: F7424982: Screenshot_20190924_094046.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://

D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread TrickyRicky
trickyricky26 updated this revision to Diff 66778. trickyricky26 added a comment. - Use butt line ending for slightly nicer asthetics REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24185?vs=66738&id=66778 BRANCH format-text-underline-squiggle (branc

D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a subscriber: ndavis. ngraham added a comment. This revision is now accepted and ready to land. @ndavis? REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread Noah Davis
ndavis added a comment. I have some improvement to the squiggle, but unfortunately, I have no internet in my house except on my phone until the 27th. REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread Noah Davis
ndavis added a comment. F7426754: 2019-09-24 22.15.33.jpg REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg, ngraham Cc: ndavis, ng

D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread Noah Davis
ndavis added a comment. F7426757: Screenshot_20190924_221218.png F7426760: Screenshot_20190924_221251.png REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISIO

D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread Noah Davis
ndavis added a comment. F7426794: Screenshot_20190924_222405.png F7426789: Screenshot_20190924_222520.png REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION D

D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread Noah Davis
ndavis added a comment. 16px F7426808: format-text-underline-squiggle.svg REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg, ngrah

D24185: Add format-text-underline-squiggle actions icons

2019-09-25 Thread TrickyRicky
trickyricky26 added a comment. In D24185#537365 , @ndavis wrote: > I have some improvements to the squiggle, but unfortunately, I have no internet in my house except on my phone until the 27th. > > basically, I > > - made a rectangle >

D24185: Add format-text-underline-squiggle actions icons

2019-09-25 Thread TrickyRicky
trickyricky26 planned changes to this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg, ngraham Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24185: Add format-text-underline-squiggle actions icons

2019-09-25 Thread TrickyRicky
trickyricky26 updated this revision to Diff 66827. trickyricky26 added a comment. This revision is now accepted and ready to land. - Use sine wave as suggested by ndavis REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24185?vs=66778&id=66827 BRANCH a

D24185: Add format-text-underline-squiggle actions icons

2019-09-25 Thread TrickyRicky
trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D24185 REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg, ngraham Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24185: Add format-text-underline-squiggle actions icons

2019-09-25 Thread Nathaniel Graham
ngraham added a comment. Not the butt ends are gone again. :) REPOSITORY R266 Breeze Icons BRANCH arcpatch-D24185 REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg, ngraham Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24185: Add format-text-underline-squiggle actions icons

2019-09-26 Thread TrickyRicky
trickyricky26 added a comment. In D24185#537880 , @ngraham wrote: > Now the butt ends are gone again. :) Yes, I think it makes more sense for this underline to be a visual crop of a longer one as they would appear in eg. LibreOffice Write

D24185: Add format-text-underline-squiggle actions icons

2019-09-26 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. All right, ship it! REPOSITORY R266 Breeze Icons BRANCH arcpatch-D24185 REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg, ngraham Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, br

D24185: Add format-text-underline-squiggle actions icons

2019-09-26 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R266:477729808ef6: Add format-text-underline-squiggle actions icons (authored by Rafael Brandmaier ). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabr