This revision was automatically updated to reflect the committed changes.
Closed by commit R216:72683653db72: Add syntax highlighting for SubRip Text
(SRT) Subtitles (authored by nibags, committed by cullmann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Thanks
REPOSITORY
R216 Syntax Highlighting
BRANCH
add-syntax-srt
REVISION DETAIL
https://phabricator.kde.org/D24211
To: nibags, #framework_syntax_highlighting, dhaumann,
nibags updated this revision to Diff 66863.
nibags added a comment.
- Undo changes in Mustache
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24211?vs=66799=66863
BRANCH
add-syntax-srt
REVISION DETAIL
https://phabricator.kde.org/D24211
dhaumann added a comment.
I'd indeed prefer another/separate diff. :)
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D24211
To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson,
nibags added a comment.
Sorry, that could go in another diff.
In the definition of Mustashe, I realized that using WordDetect requires a
delimiter before `` doesn't match the
WordDetect rule, so I changed it to RegExpr.
In HTML, I only put the Tags in a different context to make it
dhaumann added inline comments.
INLINE COMMENTS
> subrip-subtitles.xml:22
> + version="1"
> + kateversion="5.53"
> + section="Other"
What feature do you use to require 5.53 instead of 5.0?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
dhaumann added a comment.
There are also changes in other xml files. Are these intentional? E.g. the
changes from WordDetect to RegExpr seem suspicious.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D24211
To: nibags, #framework_syntax_highlighting,
nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.
REVISION SUMMARY
Add highlighting for the
