D24443: Add a plugin system

nicolasfella abandoned this revision. nicolasfella added a comment. Moving to invent: https://invent.kde.org/frameworks/kcalendarcore/-/merge_requests/20 REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim

D24443: Add a plugin system

nicolasfella planned changes to this revision. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim Cc: z3ntu, ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, dhaumann, fbampaloukas, dcaliste,

D24443: Add a plugin system

nicolasfella updated this revision to Diff 80142. nicolasfella added a comment. - Convert license headers to SPDX REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24443?vs=80141=80142 BRANCH arcpatch-D24443_2 REVISION DETAIL

D24443: Add a plugin system

nicolasfella updated this revision to Diff 80141. nicolasfella added a comment. - Remove calendarentry REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24443?vs=71067=80141 BRANCH arcpatch-D24443_2 REVISION DETAIL

D24443: Add a plugin system

nicolasfella edited the summary of this revision. nicolasfella added a dependency: D28834: Add metadata properties to calendar. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim Cc: z3ntu, ognarb, kde-pim,

D24443: Add a plugin system

nicolasfella planned changes to this revision. nicolasfella added a comment. - single level hierarchy with a calendargroup object - calendar entry folded into calendar - calendar::open REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D24443 To:

D24443: Add a plugin system

dvratil added inline comments. INLINE COMMENTS > calendarentry.cpp:36 > + > +CalendarEntry::~CalendarEntry() > +{ ` = default` (instead of empty body) > calendarentry.cpp:57 > +{ > +return ReadWrite; > +} Should that be `d->type`? How can implementations change it? Will implementation

D24443: Add a plugin system

nicolasfella updated this revision to Diff 71067. nicolasfella added a comment. - Use uniqe_ptr again REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24443?vs=71066=71067 BRANCH arcpatch-D24443_1 REVISION DETAIL

D24443: Add a plugin system

ognarb added inline comments. INLINE COMMENTS > dvratil wrote in calendarentry.h:63 > Use `std::unique_ptr const d` for automatic memory > management. This wasn't done, I still see `CalendarEntryPrivate *d;` > nicolasfella wrote in calendarplugin.h:39 > My idea was to be able to add a d-ptr

D24443: Add a plugin system

nicolasfella updated this revision to Diff 71066. nicolasfella added a comment. Herald added a project: KDE PIM. Herald added a subscriber: kde-pim. - Fix build - Rename description to name REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE

D24443: Add a plugin system

nicolasfella updated this revision to Diff 69253. nicolasfella added a comment. - Docs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24443?vs=69241=69253 BRANCH arcpatch-D24443 REVISION DETAIL https://phabricator.kde.org/D24443 AFFECTED FILES src/CMakeLists.txt

D24443: Add a plugin system

nicolasfella marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim Cc: dkardarakos, vkrause, dvratil, davidedmundson, dhaumann

D24443: Add a plugin system

nicolasfella updated this revision to Diff 69241. nicolasfella added a comment. - Put into namespace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24443?vs=69239=69241 BRANCH arcpatch-D24443 REVISION DETAIL https://phabricator.kde.org/D24443 AFFECTED FILES

D24443: Add a plugin system

nicolasfella added inline comments. INLINE COMMENTS > dvratil wrote in calendarentry.h:57 > I would move `sync()` from here to be a virtual method on the plugin - > `sync(const CalendarEntry::Ptr &)`. The implementations would reimplement it > to handle sync, which feels cleaner than having to

D24443: Add a plugin system

nicolasfella updated this revision to Diff 69239. nicolasfella marked 9 inline comments as done. nicolasfella added a comment. - Drop property - Use QVector - Use unique_ptr - Make unique_ptr const - Comments - Make calendars pure virtual - ref CHANGES SINCE LAST UPDATE

D24443: Add a plugin system

dvratil added a comment. - I would add `name` property to the `CalendarEntry` - I would add `color` property to the `CalendarEntry`, so that calendar that is e.g. green in KOrganizer would show up green in the Plasma applet, too. The Akonadi plugin for this will need to expose a list

D24443: Add a plugin system

vkrause added a reviewer: KDE PIM. REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim Cc: vkrause, dvratil, davidedmundson, dhaumann

D24443: Add a plugin system

vkrause added a comment. In D24443#543140 , @vkrause wrote: > - Is KDeclarative is the right place for this? It's a module on the way out in KF6, it is hard to build for Android due to its dependency chain (which isn't even needed for this),

D24443: Add a plugin system

vkrause added subscribers: dvratil, vkrause. vkrause added a comment. Thanks for working on this! Some general thoughts: - Is KDeclarative is the right place for this? It's a module on the way out in KF6, it is hard to build for Android due to its dependency chain (which isn't even

D24443: Add a plugin system

davidedmundson added a comment. Plan makes sense. INLINE COMMENTS > calendarentry.h:35 > +Q_PROPERTY(CalendarType type READ type CONSTANT) > +Q_PROPERTY(KCalendarCore::Calendar::Ptr calendar READ calendar CONSTANT) > +public: If the intention is for QML to be able to get and access

D24443: Add a plugin system

dhaumann added a comment. I'd go for a QVector for now. Arguing with Qt6 doesn't sound convincing to me, since Qt6 will take another>=1 year(s). So why try this experiment in public API now? :) REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma Cc:

D24443: Add a plugin system

nicolasfella edited the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma

D24443: Add a plugin system

nicolasfella added a comment. Something I'm unsure about is the usage of std::vector in public API. We never really did that, but given Qt6 is ahead we might want to consider doing it from now on REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma

D24443: Add a plugin system

nicolasfella edited the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma

D24443: Add a plugin system

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, Plasma. nicolasfella requested review of this revision. REVISION SUMMARY This allows applications/services (e.g. Akonadi, Sink, KHolidays etc) to provide calendar content to other applications/services (e.g.