D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

2019-11-11 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R320:49440c0cbea1: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

2019-10-21 Thread Méven Car
meven added a comment. In D24686#550567 , @elvisangelaccio wrote: > It's always ok to bump the KF5 version as long as you do it before the dependency freeze day set by the release team. So I guess it is the case here : Apps 19.12 is

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

2019-10-20 Thread David Faure
dfaure added a comment. Thanks for the information. https://community.kde.org/Schedules doesn't have a 19.12 schedule so I guess there's no freeze yet :-) REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D24686 To: meven, dfaure Cc:

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

2019-10-20 Thread Elvis Angelaccio
elvisangelaccio added a comment. In D24686#550533 , @dfaure wrote: > I never know when it's OK to increase the KF5 version dependency from applications modules, though. > > I have a ton of pending patches (to port away from KWindowSystem

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

2019-10-20 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I never know when it's OK to increase the KF5 version dependency from applications modules, though. I have a ton of pending patches (to port away from KWindowSystem deprecated API)

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

2019-10-16 Thread Méven Car
meven created this revision. meven added a reviewer: dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY With D23523 and D24582