This revision was automatically updated to reflect the committed changes.
Closed by commit R282:4a6a5e708077: Add support for SAE authentication used by
WPA3 (authored by jgrulich).
REPOSITORY
R282 NetworkManagerQt
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24689?vs=68156&id=6815
jgrulich marked an inline comment as done.
REPOSITORY
R282 NetworkManagerQt
BRANCH
wpa3
REVISION DETAIL
https://phabricator.kde.org/D24689
To: jgrulich, #frameworks, meven
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
jgrulich updated this revision to Diff 68156.
jgrulich added a comment.
- Coding style
REPOSITORY
R282 NetworkManagerQt
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24689?vs=68029&id=68156
BRANCH
wpa3
REVISION DETAIL
https://phabricator.kde.org/D24689
AFFECTED FILES
src
meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.
Seems good to me, but I might not be the best person to approve this.
INLINE COMMENTS
> utils.cpp:355
> +}
> + if (apRsn.testFlag(NetworkManager::AccessPoint::Pa
jgrulich added a dependent revision: D24691: Add support for WPA3.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D24689
To: jgrulich, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
jgrulich updated this revision to Diff 68029.
jgrulich added a comment.
Compare against lowercase value
REPOSITORY
R282 NetworkManagerQt
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24689?vs=68028&id=68029
BRANCH
wpa3
REVISION DETAIL
https://phabricator.kde.org/D24689
AFF
jgrulich added a reviewer: Frameworks.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D24689
To: jgrulich, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
jgrulich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jgrulich requested review of this revision.
REPOSITORY
R282 NetworkManagerQt
BRANCH
wpa3
REVISION DETAIL
https://phabricator.kde.org/D24689
AFFECTED FILES
src/accesspoint