D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Can go in, but I'd still suggest starting the separate class now. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D24695 To: meven, #frameworks, ko

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

kossebau added a comment. IMHO such idea notes should also be put into the source file or, better, a separate TODO file in the toplevel source, not the header (which is going to be deployed as part of devel-packages), as this note is uninteresting to users of current KXMLGUIClient. REPOSITO

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

dfaure added a comment. OK, next step is to consider writing that separate class now rather than hoping to dump that task on a random future reader of the TODO ;-) At least, starting it is the best way to find out how feasible it is. REPOSITORY R263 KXmlGui REVISION DETAIL https://phab

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

meven updated this revision to Diff 68067. meven added a comment. Update TODO REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24695?vs=68043&id=68067 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24695 AFFECTED FILES src/kxmlguiclient.h

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

meven added a comment. In D24695#548248 , @dfaure wrote: > In my experience 90 % of the users of this class don't care for the state feature, so I would rather move it to a separate class. > > Also this class is used everywhere, so the change

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

dfaure added a comment. In my experience 90 % of the users of this class don't care for the state feature, so I would rather move it to a separate class. Also this class is used everywhere, so the change would have massive repercussions, while most users (both subclasses and code using a

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

meven added a comment. This is just to make sure this TODO makes sense and is consensual. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D24695 To: meven, #frameworks, kossebau, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

meven created this revision. meven added reviewers: Frameworks, kossebau, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY To avoid string typing, replace usage of string with a proper enum defi