D24754: Fix KNSCore::Cache fetching when initialising Engine

2019-10-21 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R304:8977627cab85: Fix KNSCore::Cache fetching when initialising Engine (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24754?vs=68284&id=68404 R

D24754: Fix KNSCore::Cache fetching when initialising Engine

2019-10-19 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 68284. leinir added a comment. - Ensure that the config filename only has the base name REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24754?vs=68227&id=68284 BRANCH fix-knscore-cache (branched from master) REVISIO

D24754: Fix KNSCore::Cache fetching when initialising Engine

2019-10-18 Thread Rik Mills
rikmills accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH fix-knscore-cache (branched from master) REVISION DETAIL https://phabricator.kde.org/D24754 To: leinir, rikmills, #frameworks, #knewstuff Cc: kde-frameworks-devel, LeGast00n,

D24754: Fix KNSCore::Cache fetching when initialising Engine

2019-10-18 Thread Rik Mills
rikmills added a comment. Patched knewstuff build with this and tested. Switching between KCMs in systemsettings now seems to pull the correct KNS results. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D24754 To: leinir, rikmills, #frameworks, #knewstuff Cc: kde-

D24754: Fix KNSCore::Cache fetching when initialising Engine

2019-10-18 Thread Dan Leinir Turthra Jensen
leinir added reviewers: rikmills, Frameworks, KNewStuff. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D24754 To: leinir, rikmills, #frameworks, #knewstuff Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24754: Fix KNSCore::Cache fetching when initialising Engine

2019-10-18 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 68227. leinir added a comment. - Revert unrelated change REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24754?vs=68226&id=68227 BRANCH fix-knscore-cache (branched from master) REVISION DETAIL https://phabricator.

D24754: Fix KNSCore::Cache fetching when initialising Engine

2019-10-18 Thread Dan Leinir Turthra Jensen
leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY During the moving-around of the config files, the Cache was left behind unfixed, and we ended up with all caches being t