D24887: WIP slave command behavior assertion system

2020-04-14 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. After much delay some replies but there are yet more questions in here INLINE COMMENTS > commands_p.h:27 > { > +#pragma message "this is awkward since this causes

D24887: WIP slave command behavior assertion system

2019-10-25 Thread Harald Sitter
sitter added a comment. About the list of unexpected signals in forCommand(): It looks that at least http, ftp, and sftp do call connected() as part of various commands. e.g. all do it during get(). Does that make sense? connected() refers to openConnection() in its documentation, and

D24887: WIP slave command behavior assertion system

2019-10-23 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY This implements a simple expectation system covering slave commands. At its heart sits