D25067: Fix the header layouts for EntryDetails and Page components

This revision was automatically updated to reflect the committed changes. Closed by commit R304:4d56727cc7d7: Fix the header layouts for EntryDetails and Page components (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D25067: Fix the header layouts for EntryDetails and Page components

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH fix-page-and-entrydetails-headers (branched from master) REVISION DETAIL https://phabricator.kde.org/D25067 To: leinir, ngraham, #knewstuff, #frameworks, #plasma Cc:

D25067: Fix the header layouts for EntryDetails and Page components

leinir updated this revision to Diff 69319. leinir marked 6 inline comments as done. leinir added a comment. - Remove the custom title delegate on EntryDetails REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25067?vs=69281=69319 BRANCH

D25067: Fix the header layouts for EntryDetails and Page components

leinir added inline comments. INLINE COMMENTS > ahiemstra wrote in EntryDetails.qml:94 > Hmm, with the new toolbar code, there's actually little reason to use a > custom delegate here, since the toolbar header already uses a title + tool > buttons style. You could convert the three toolbuttons

D25067: Fix the header layouts for EntryDetails and Page components

ahiemstra added inline comments. INLINE COMMENTS > EntryDetails.qml:94 > title: i18nc("Combined title for the entry details page made of the name > of the entry, and the author's name", "%1 by > %2").arg(component.name).arg(entryAuthor.name) > titleDelegate: QtLayouts.RowLayout { > +

D25067: Fix the header layouts for EntryDetails and Page components

leinir added a comment. In D25067#558557 , @ngraham wrote: > With that Kirigami patch, this *almost* works. There's still an empty area on the right: > > F7735292: Screenshot_20191104_092108.png >

D25067: Fix the header layouts for EntryDetails and Page components

ngraham added a comment. With that Kirigami patch, this *almost* works. There's still an empty area on the right: F7735292: Screenshot_20191104_092108.png F7735295: Screenshot_20191104_092215.png

D25067: Fix the header layouts for EntryDetails and Page components

leinir added a comment. In D25067#558557 , @ngraham wrote: > With that Kirigami patch, this *almost* works. There's still an empty area on the right: > > F7735292: Screenshot_20191104_092108.png >

D25067: Fix the header layouts for EntryDetails and Page components

leinir updated this revision to Diff 69281. leinir added a comment. Thanks to @ahiemstra for helping out with the Kirigami side :) - Switch to using layouts (and massively simplify the sizing logic) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D25067: Fix the header layouts for EntryDetails and Page components

leinir added a dependency: D25141: Use a RowLayout for laying out ToolBarPageHeader. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25067 To: leinir, ngraham, #knewstuff, #frameworks, #plasma Cc: ahiemstra, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25067: Fix the header layouts for EntryDetails and Page components

leinir added a comment. In D25067#557225 , @ngraham wrote: > Now that's fixed on the main page but it's missing margins on the right side: F7702718: Screenshot_20191031_081429.png Right,

D25067: Fix the header layouts for EntryDetails and Page components

ngraham added a comment. Now that's fixed on the main page but it's missing margins on the right side: F7702718: Screenshot_20191031_081429.png And it's still broken on details pages: F7702721: Screenshot_20191031_081517.png

D25067: Fix the header layouts for EntryDetails and Page components

leinir added inline comments. INLINE COMMENTS > ahiemstra wrote in EntryDetails.qml:95 > It does not. I am also unsure whether `anchors.fill` will work, since the > titleDelegate is instantiated by a loader and its sizing behaviour is > somewhat fuzzy. The only option that is guaranteed to

D25067: Fix the header layouts for EntryDetails and Page components

leinir updated this revision to Diff 69067. leinir added a comment. Based on @ahiemstra's comments on the sizing logic, this seems to work... - Switch to an implicitWidth based approach REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D25067: Fix the header layouts for EntryDetails and Page components

ahiemstra added inline comments. INLINE COMMENTS > ngraham wrote in EntryDetails.qml:95 > I don't think this works, since it's not inside another layout. Instead maybe > `anchors.fill: parent` would work better? It does not. I am also unsure whether `anchors.fill` will work, since the

D25067: Fix the header layouts for EntryDetails and Page components

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Close, but not quite: F7695250: Screenshot_20191030_095130.png F7695252: Screenshot_20191030_095200.png

D25067: Fix the header layouts for EntryDetails and Page components

leinir added reviewers: Frameworks, Plasma. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25067 To: leinir, ngraham, #knewstuff, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25067: Fix the header layouts for EntryDetails and Page components

leinir edited the test plan for this revision. leinir added reviewers: ngraham, KNewStuff. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25067 To: leinir, ngraham, #knewstuff Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25067: Fix the header layouts for EntryDetails and Page components

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This ensures that the header is the correct width, and further that the text does not disappear when there is no space