D25149: Add a new template for KCMs

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > %{APPNAMELC}settings.kcfg:8 > + > + > + The Exam Now that I think about it, what about using both key and name here? To have a nice property name an

D25149: Add a new template for KCMs

tcanabrava marked 2 inline comments as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25149 To: tcanabrava, #plasma, #frameworks, mart, ervin Cc: #plasma, GB_2, yurchor, davidedmundson, ognarb, ervin, kde-frameworks-devel, LeGast00n, The-Feren-

D25149: Add a new template for KCMs

tcanabrava marked 6 inline comments as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25149 To: tcanabrava, #plasma, #frameworks, mart, ervin Cc: #plasma, GB_2, yurchor, davidedmundson, ognarb, ervin, kde-frameworks-devel, LeGast00n, The-Feren-

D25149: Add a new template for KCMs

tcanabrava updated this revision to Diff 71009. tcanabrava marked an inline comment as done. tcanabrava added a comment. - Fix indentation REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25149?vs=69942&id=71009 BRANCH arcpatch-D25149 R

D25149: Add a new template for KCMs

ervin added inline comments. INLINE COMMENTS > kcm.cpp:37 > +KAboutData* about = new KAboutData( > +QStringLiteral("kcm_%{APPNAMELC}"), i18n("%{APPNAME} Configuration > Module"), > +QStringLiteral("0.1"), QString(), KAboutLicense::GPL, Nitpick: indentation looks broken here, I think

D25149: Add a new template for KCMs

tcanabrava updated this revision to Diff 69942. tcanabrava added a comment. - Handle immutability REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25149?vs=69941&id=69942 BRANCH arcpatch-D25149 REVISION DETAIL https://phabricator.kde.

D25149: Add a new template for KCMs

tcanabrava updated this revision to Diff 69941. tcanabrava marked an inline comment as done. tcanabrava added a comment. - Adapt to ManagedConfigModule REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25149?vs=69649&id=69941 BRANCH arcpa

D25149: Add a new template for KCMs

ervin added inline comments. INLINE COMMENTS > tcanabrava wrote in kcm.cpp:43 > What's the correct form then? No need to connect the settings *at all*? No need indeed... it's *magic*! ;-) > tcanabrava wrote in main.qml:39 > The default fake setting will not be immutable, or you mean that you wa

D25149: Add a new template for KCMs

tcanabrava added inline comments. INLINE COMMENTS > ervin wrote in kcm.cpp:43 > Shouldn't be needed anymore (and likely wrong in most cases). What's the correct form then? No need to connect the settings *at all*? > ervin wrote in main.qml:39 > What about disabling it if the setting is immutabl

D25149: Add a new template for KCMs

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > %{APPNAMELC}settings.kcfgc:5 > +DefaultValueGetters=true > +GenerateProperties=true You also want "ParentInConstructor=true" in here. > kcm.cpp:32 > +: KQu

D25149: Add a new template for KCMs

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D25149 REVISION DETAIL https://phabricator.kde.org/D25149 To: tcanabrava, #plasma, #frameworks, mart Cc: #plasma, GB_2, yurchor, davidedmundson, ognarb,

D25149: Add a new template for KCMs

tcanabrava updated this revision to Diff 69649. tcanabrava marked 2 inline comments as done. tcanabrava added a comment. - Add KConfigXT - Remove wrong icon REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25149?vs=69400&id=69649 BRANCH

D25149: Add a new template for KCMs

GB_2 added reviewers: Plasma, Frameworks. GB_2 added a project: Plasma. GB_2 added a subscriber: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25149 To: tcanabrava, #plasma, #frameworks Cc: #plasma, GB_2, yurchor, davidedmundson, ognarb, ervi

D25149: Add a new template for KCMs

GB_2 added a comment. In D25149#559684 , @tcanabrava wrote: > We need a better icon. it's the icon for the `Plasmoid` template. Why not use the system settings icon as it's a KCM template? REPOSITORY R242 Plasma Framework (Library) RE

D25149: Add a new template for KCMs

ngraham retitled this revision from "Add a new Template for KCM's." to "Add a new template for KCMs". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25149 To: tcanabrava Cc: yurchor, davidedmundson, ognarb, ervin, kde-frameworks-devel, LeGast00n, GB