D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ngraham created this revision. ngraham added reviewers: VDG, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 413002 FIXED-IN: 5.65 Undecided on the button. Should it be text-o

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ngraham added a comment. Or maybe should the UI be changed to show a clickable link and an "edit" button that temporarily turns it into a text field that lets you edit it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25226 To: ngraham, #vdg, #frameworks Cc: kde-frame

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ndavis added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1120 > +QPushButton *goThereButton = new QPushButton(d->m_frame); > +goThereButton->setIcon(QIcon::fromTheme(QStringLiteral("go-next"))); > + `go-jump` is more semantically correct. REPOSITORY R241 KIO REVI

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ndavis added a comment. In D25226#560363 , @ngraham wrote: > Or maybe should the UI be changed to show a clickable link and an "edit" button that temporarily turns it into a text field that lets you edit it? So like this? __​/media/e

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ngraham added a comment. Actually I played with that and in retrospect I don't think it would work. If we give it a "link-like" appearance, that would suggest that clicking on it would actually open the destination file/folder (i.e. the typical link behavior), which is not what we want here.

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ngraham updated this revision to Diff 69684. ngraham marked an inline comment as done. ngraham added a comment. Use more semantically correct icon REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25226?vs=69493&id=69684 BRANCH show-link-target-in-properties-di

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ngraham added a comment. Last question: give the button text, or stick with the icon only? I ask because `go-jump` is kind of an odd icon IMO: F7761220: Screenshot_20191113_093303.png REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ngraham added a comment. Ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25226 To: ngraham, #vdg, #frameworks Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

apol added a comment. +1 LGTM REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25226 To: ngraham, #vdg, #frameworks Cc: apol, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:4d8aa4be386e: [KPropertiesDialog] provide a way of showing the target of a symlink (authored by ngraham). REPOSITORY