D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found

2019-12-13 Thread Méven Car
meven abandoned this revision. meven added a comment. In favor of D25891 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25323 To: meven, kossebau, cullmann, vkrause Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fpr

D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found

2019-12-11 Thread Friedrich W. H. Kossebau
kossebau added a comment. See D25891 (not tested by myself, only saw it) for another approach to this. So seems in general setTheme() always needs an explicit rehighlight() afterwards (but why only in some cases)? AbstractHighlighter::setTheme claims tha

D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found

2019-11-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25323#562989 , @meven wrote: > In D25323#562908 , @kossebau wrote: > > > Thanks for looking at the issue. No time to look closer the next days, but curious about this p

D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found

2019-11-15 Thread Méven Car
meven added a comment. In D25323#562908 , @kossebau wrote: > Thanks for looking at the issue. No time to look closer the next days, but curious about this partial change (which has been discussed before and discarded): > changing `QColor ( 24

D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found

2019-11-15 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25323 To: meven, kossebau, cullmann, vkrause Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew

D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found

2019-11-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. Also am I wonfering how this relates to the bug report you referred to? Can you tell what effect your code change has on the symptoms reported in https://bugs.kde.org/show_bug.cgi?id=409380#c0 ? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde

D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found

2019-11-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. Thanks for looking at the issue. No time to look closer the next days, but curious about this partial change (which has been discussed before and discarded): changing `QColor ( 245, 245, 245 ); // light-grey background ` to `highlightingTheme.editorColor(KSyntaxHi

D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found

2019-11-15 Thread Méven Car
meven created this revision. meven added reviewers: kossebau, cullmann, vkrause. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY By default KSyntaxHighlighter does not highlight text