D25334: Added transparent blue background to tabbars

ngraham added a comment. Is there a reason why we can't do this? I like it... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg, ngraham, ndavis Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, cblac

D25334: Added transparent blue background to tabbars

niccolove abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg, ngraham, ndavis Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#578285 , @niccolove wrote: > Breeze dark highlight is currently #3daee9 in the Breeze Dark colorscheme. If that's too light, we could darken it there, right? > Currently it's: F7819764: Screenshot_20191215_16

D25334: Added transparent blue background to tabbars

niccolove added a comment. Breeze dark highlight is currently #3daee9 in the Breeze Dark colorscheme. If that's too light, we could darken it there, right? Currently it's: F7819764: Screenshot_20191215_163924.png Darker could be (example value): F7

D25334: Added transparent blue background to tabbars

niccolove added a comment. In D25334#566992 , @ngraham wrote: > In D25334#566745 , @ndavis wrote: > > > Yes that's right, the Kickoff tabs are fine, it's the panel that doesn't look right. It just do

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#566992 , @ngraham wrote: > In D25334#566745 , @ndavis wrote: > > > Yes that's right, the Kickoff tabs are fine, it's the panel that doesn't look right. It just doesn

D25334: Added transparent blue background to tabbars

ngraham added a comment. In D25334#566745 , @ndavis wrote: > Yes that's right, the Kickoff tabs are fine, it's the panel that doesn't look right. It just doesn't look good with that kind of highlight to me. Or maybe the highlight background is t

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#566524 , @niccolove wrote: > F7780227: Screenshot_20191123_130602.png > I'm sorry, isn't this right? > The top one was like that before, and I just edited the bottom

D25334: Added transparent blue background to tabbars

niccolove added a comment. F7780227: Screenshot_20191123_130602.png I'm sorry, isn't this right? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg, ngraham, ndavis Cc: ngraham, ndavi

D25334: Added transparent blue background to tabbars

ndavis added a comment. Here's the fixed file: F680: tabbar.svg Unfortunately, it still doesn't look right. F681: Screenshot_20191121_160905.png REPOSITORY R242 Plasma Framework (Library) REVISION DE

D25334: Added transparent blue background to tabbars

ndavis added inline comments. INLINE COMMENTS > ndavis wrote in tabbar.svg:47 > Oh wait, this must be where the color problem is. It's hardcoded to a light > color. It should be ButtonFocus with semi-transparency instead. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://

D25334: Added transparent blue background to tabbars

ndavis added inline comments. INLINE COMMENTS > tabbar.svg:47 > + > + height="12" fill="#93cee9" opacity=".34"/> > + height="12" fill="#93cee9" opacity=".34"/> Oh wait, this must be where the color problem is. It's hardcoded to a light color. REPOSITORY R242 Plasma Fr

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#565851 , @ngraham wrote: > Are you talking about the effect itself in terms of its background color, or how it fits in the space available when displayed by widgets? The latter will require many complicated chan

D25334: Added transparent blue background to tabbars

ngraham added a comment. Are you talking about the effect itself in terms of its background color, or how it fits in the space available when displayed by widgets? The latter will require many complicated changes in various places to fix, but can't the former be fixed in this patch? REPOSIT

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#565798 , @ngraham wrote: > Honestly I think this is fine to land now. We can incrementally improve things with patches to individual widgets, but for the most part I think this is a big improvement already.

D25334: Added transparent blue background to tabbars

ngraham added a comment. Honestly I think this is fine to land now. We can incrementally improve things with patches to individual widgets, but for the most part I think this is a big improvement already. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde

D25334: Added transparent blue background to tabbars

ngraham added a comment. In D25334#563841 , @ndavis wrote: > Even if the colors are fixed, there are a number of other places that need fixes in order for this to look right, so I think we should hold off landing this until these issues are fixe

D25334: Added transparent blue background to tabbars

ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg, ngraham, ndavis Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n

D25334: Added transparent blue background to tabbars

ndavis added a comment. Even if the colors are fixed, there are a number of other places that need fixes in order for this to look right, so I think we should hold off landing this until these issues are fixed: Not extending to the edge: F7768790: Screenshot_20191117_171047.png

D25334: Added transparent blue background to tabbars

ndavis added a comment. These colors don't look right F7768670: Screenshot_20191117_152000.png REPOSITORY R242 Plasma Framework (Library) BRANCH tabbar_blue_background (branched from master) REVISION DETAIL https://phabricator.kde.org/D25334 T

D25334: Added transparent blue background to tabbars

ngraham accepted this revision. ngraham added a comment. This seems perfect to me. A big visual improvement IMO. Any objections? REPOSITORY R242 Plasma Framework (Library) BRANCH tabbar_blue_background (branched from master) REVISION DETAIL https://phabricator.kde.org/D25334 To: nicco

D25334: Added transparent blue background to tabbars

niccolove updated this revision to Diff 69879. niccolove added a comment. Resized 2px tabbar line to 3px REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25334?vs=69841&id=69879 BRANCH tabbar_blue_background (branched from master) REVIS

D25334: Added transparent blue background to tabbars

ngraham added a comment. Can you remove the line width changes from this? When this patch just adds the transparent blue background, I think it's pretty uncontroversial and read to land quickly. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabrica

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#563295 , @niccolove wrote: > In D25334#563285 , @ngraham wrote: > > > Perfect, all issues fixed, and thanks for pointing me in the direction of the cache files. D

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#563346 , @ngraham wrote: > Found the bug report tracking that requested change: https://bugs.kde.org/show_bug.cgi?id=370465 > > Based on the comments there, it's likely that this proposal would receive pushb

D25334: Added transparent blue background to tabbars

ngraham added a comment. In D25334#563345 , @niccolove wrote: > In D25334#563334 , @ngraham wrote: > > > If you wanna do that, let's split it out into a different patch though. > > > Sure. Sho

D25334: Added transparent blue background to tabbars

ngraham added a comment. Found the bug report tracking that requested change: https://bugs.kde.org/show_bug.cgi?id=370465 Based on the comments there, it's likely that this proposal would receive pushback, and we should endeavor to understand why it was changed to the current state in t

D25334: Added transparent blue background to tabbars

niccolove added a comment. In D25334#563334 , @ngraham wrote: > If you wanna do that, let's split it out into a different patch though. Sure. Should this patch land first, or should I try to make two at the same time? REPOSITORY R242 P

D25334: Added transparent blue background to tabbars

ngraham added a comment. If you wanna do that, let's split it out into a different patch though. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg, ngraham Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-framewo

D25334: Added transparent blue background to tabbars

ngraham added a comment. In D25334#563308 , @niccolove wrote: > F7766720: Screenshot_20191116_172052.png > I think that this last one looks much prettier and usable, but that's just an idea I only wante

D25334: Added transparent blue background to tabbars

niccolove added a comment. In D25334#563301 , @ngraham wrote: > If anything, I think the tab bar line should increase to be 3px to match the open app task manager highlight. If we do the reverse, the highlight for open app swill be too subtle IM

D25334: Added transparent blue background to tabbars

ngraham added a comment. If anything, I think the tab bar line should increase to be 3px to match the open app task manager highlight. If we do the reverse, the highlight for open app swill be too subtle IMO. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL ht

D25334: Added transparent blue background to tabbars

niccolove added a comment. In D25334#563285 , @ngraham wrote: > Perfect, all issues fixed, and thanks for pointing me in the direction of the cache files. Deleting those fixed a bunch of other issues I was having with applying plasma theme SVG

D25334: Added transparent blue background to tabbars

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Perfect, all issues fixed, and thanks for pointing me in the direction of the cache files. Deleting those fixed a bunch of other issues I was having with applying plasma theme SVG change

D25334: Added transparent blue background to tabbars

niccolove added a comment. In D25334#563265 , @ngraham wrote: > Did you change the SVGs for vertical tab bars as well? Uh, yes I did. Try deleting the plasma theme + svg cache in .cache > I also noticed one visual papercut in the plas

D25334: Added transparent blue background to tabbars

niccolove updated this revision to Diff 69841. niccolove added a comment. Fixed broken north bottom-left tabbar line REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25334?vs=69840&id=69841 BRANCH master REVISION DETAIL https://phabri

D25334: Added transparent blue background to tabbars

ngraham added subscribers: ndavis, ngraham. ngraham added a comment. This is great, I've wanted Plasma tabs to look like this for ages. It gels very well with the in-progress highlight changes that @ndavis is working on. However for me it only seems to take effect for horizontal tab bars. Did

D25334: Added transparent blue background to tabbars

niccolove added a comment. In D25334#563254 , @KonqiDragon wrote: > Something like this looks better and clearer. > F6924045: grafik.png That's because no element was selected. If you select an el

D25334: Added transparent blue background to tabbars

KonqiDragon added a comment. Is it possible to make the selection of system tray visually more cleary? On this screenshot i see that opened the "Status and Notifications" tray popup, but it looks like that selected all in the system tray F7766344: Screenshot_20191116_121454.png

D25334: Added transparent blue background to tabbars

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg Cc: #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

niccolove updated this revision to Diff 69840. niccolove edited the summary of this revision. niccolove added a comment. Resized blue line of tabbars REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25334?vs=69833&id=69840 BRANCH master

D25334: Added transparent blue background to tabbars

niccolove edited the summary of this revision. niccolove edited the test plan for this revision. niccolove added a reviewer: VDG. niccolove added a subscriber: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg Cc: #vdg, kde

D25334: Added transparent blue background to tabbars

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Used the T11124 highlight effect for breeze tabbars by editing the file widget