astippich created this revision.
astippich added reviewers: Baloo, bruns, mgallien, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
astippich requested review of this revision.
REVISION SUMMARY
prepare for the following patch to taglibextractor
astippich added a dependent revision: D25518: Extract front cover in the taglib
extractor.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D25517
To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampalouka
ngraham accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
binaryData
REVISION DETAIL
https://phabricator.kde.org/D25517
To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, f
astippich updated this revision to Diff 70303.
astippich added a comment.
- fix label comment
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25517?vs=70284&id=70303
BRANCH
binaryData
REVISION DETAIL
https://phabricator.kde.org/D25517
AFFECTED F
bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> extractionresult.h:61
> + */
> +ExtractBinaryData = 4,
> +ExtractEverythingIncludingBinary = (ExtractEverything |
> ExtractBinaryData),
Bi
astippich added inline comments.
INLINE COMMENTS
> bruns wrote in extractionresult.h:61
> Binary is **how**, not **what**.
Do you have a suggestion for a better name? I tried to be as generic as
possible. It could be named more specifically ExtractImages, since this is what
it will be primaril
astippich updated this revision to Diff 70723.
astippich added a comment.
- fix label comment
- tweaks
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25517?vs=70303&id=70723
BRANCH
binaryData
REVISION DETAIL
https://phabricator.kde.org/D25517
astippich added a comment.
ping!
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D25517
To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2,
domson, ashaposhnikov, michaelh, astippich, s
astippich updated this revision to Diff 71623.
astippich added a comment.
- rename flag to ImageData
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25517?vs=70723&id=71623
BRANCH
binaryData
REVISION DETAIL
https://phabricator.kde.org/D25517
AFF
