D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

crossi abandoned this revision. crossi added a comment. No longer need since 866d3f45b84e REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25520 To: crossi, #plasma, ervin, bport, mart,

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. test with kirigami master and let's reevaluate later if this is still needed REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25520 To: crossi, #plasma,

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

mart added a comment. now Kirigami.WheelHandler doesn't scroll disabled views anymore. This may be enough to not require this (just view.enabled: false), perhaps scrollbars and background could update their look as well on the style side. REPOSITORY R296 KDeclarative REVISION DETAIL ht

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

ervin added a comment. In D25520#567651 , @broulik wrote: > Alternatively we could fix the scroll view container taking into account the `scroll` enabled, so that `view.enabled` does the right thing You mean the other way around right? Li

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

davidedmundson added a comment. Yeah, but we clearly have at least one reason to break the encapsulation. I can imagine a need to externally force scroll position. I'm not forcing my version either, just wanted it considered @notmart I think you have final call? > Alternatively

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

broulik added a comment. Alternatively we could fix the scroll view container taking into account the `scroll` enabled, so that `view.enabled` does the right thing REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25520 To: crossi, #plasma, ervin, bport, mart, da

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

ervin added a comment. In D25520#567644 , @davidedmundson wrote: > Throwing out an alternative suggestion > > readonly property alias gridContainer: scroll > > > (and then your code calling gridContainer.enabled = whatever) > > I

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

davidedmundson added a comment. Throwing out an alternative suggestion readonly property alias gridContainer: scroll (and then your code calling gridContainer.enabled = whatever) It's more generic for any future stuff, and it solves the issue of trying to convey the differenc

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25520 To: crossi, #plasma, ervin, bport, mart, davidedmundson Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

crossi added a dependent revision: D25525: KCM Style : take into account immutable properties. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25520 To: crossi, #plasma, ervin, bport, mart, davidedmundson Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

crossi added a comment. In D25520#567254 , @broulik wrote: > Can't you do `view.enabled: false`? > Edit: Never mind, `view` is bound to `scroll.view`, not `scroll` I did, but the GridView's style was not updateed to show it was disabled

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

broulik added a comment. Can't you do `view.enabled: false`? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25520 To: crossi, #plasma, ervin, bport, mart, davidedmundson Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, mart, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. crossi requested review of this revision. REVISION SUMMARY Some KCM use GridViewKCM as root item, and they may ha