D25545: Rename signal for avoiding overload signal

This revision was automatically updated to reflect the committed changes. Closed by commit R246:f6f6aa244b55: Rename signal for avoiding overload signal (authored by mlaurent). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25545?vs=70410&id=70476 REVISION DET

D25545: Rename signal for avoiding overload signal

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH deprecated_overload_signal (branched from master) REVISION DETAIL https://phabricator.kde.org/D25545 To: mlaurent, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, mich

D25545: Rename signal for avoiding overload signal

mlaurent updated this revision to Diff 70410. mlaurent added a comment. Fix some errors REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25545?vs=70394&id=70410 BRANCH deprecated_overload_signal (branched from master) REVISION DETAIL https://phabricator.

D25545: Rename signal for avoiding overload signal

kossebau added inline comments. INLINE COMMENTS > Doxyfile.local:4 > +# define so that deprecated API is not skipped > +PREDEFINED += \ > +"KCOREADDONS_ENABLE_DEPRECATED_SINCE(x, y)=1" \ The predefined macros we want to tell doxygen about in the case of kapidox (being run in a non-build che

D25545: Rename signal for avoiding overload signal

mlaurent updated this revision to Diff 70394. mlaurent added a comment. Fix indent REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25545?vs=70393&id=70394 BRANCH deprecated_overload_signal (branched from master) REVISION DETAIL https://phabricator.kde.o

D25545: Rename signal for avoiding overload signal

mlaurent updated this revision to Diff 70393. mlaurent added a comment. Add apidox options REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25545?vs=70347&id=70393 BRANCH deprecated_overload_signal (branched from master) REVISION DETAIL https://phabricat

D25545: Rename signal for avoiding overload signal

kossebau added a comment. In D25545#568090 , @dfaure wrote: > Looks good to me. Friedrich, what did we conclude about deprecating signals? From https://phabricator.kde.org/D24466#547023 & ff. I took with me that deprecating signals like m

D25545: Rename signal for avoiding overload signal

dfaure added a reviewer: kossebau. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25545 To: mlaurent, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25545: Rename signal for avoiding overload signal

dfaure added a comment. Looks good to me. Friedrich, what did we conclude about deprecating signals? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25545 To: mlaurent, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25545: Rename signal for avoiding overload signal

mlaurent added a reviewer: dfaure. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25545 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25545: Rename signal for avoiding overload signal

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY New signal for replacing done(const QString &) TEST PLAN build REPOSITORY R246 Sonnet BRANCH deprecated_overl