This revision was automatically updated to reflect the committed changes.
Closed by commit R304:834e52ee4bd9: Add some friendly "report bugs
here" links (authored by leinir).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25562?vs=70733&id=70822
REVISION DE
ngraham accepted this revision.
REPOSITORY
R304 KNewStuff
BRANCH
helpful-linking-for-bugs (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25562
To: leinir, #frameworks, #knewstuff, ngraham, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, br
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R304 KNewStuff
BRANCH
helpful-linking-for-bugs (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25562
To: leinir, #frameworks, #knewstuff, ngraham, davidedmundson
Cc: kde-
leinir updated this revision to Diff 70733.
leinir added a comment.
- Merge branch 'master' into helpful-linking-for-bugs
- Don't use .arg, just embed the URLs directly in the translatable text
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25562?vs=704
ngraham added a comment.
Instead of using `.arg()`, just put the variable inline, inside the i18n
call. This is less fragile and less likely to produce visible i18n errors in
the UI.
Also, screenshots in the Test Plan section are always appreciated for
user-visible changes. :)
REPOSITO
leinir added reviewers: Frameworks, KNewStuff, ngraham.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D25562
To: leinir, #frameworks, #knewstuff, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.
REVISION SUMMARY
Add a link to the FeedbackOverlay's "report-a-bug-please" bit
Also add the link to EntryDetails (and remove some debu
