D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson added a comment. > From the viewpoint of baloo_file, the process just hangs, which is bad. Ok, I can add support for passing the error down to baloo_file. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns, ngraham Cc:

D25583: Quit baloo_file_extractor if DB transaction fails

bruns added a comment. From the viewpoint of baloo_file, the process just hangs, which is bad. INLINE COMMENTS > app.cpp:138 > > QDBusConnection::sessionBus().send(message); > You still send out the message, though the results have not been commited. REPOSITORY R293 Baloo

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson added a comment. I'm going to push soon if I don't hear soon. It solves a real world problem and it's had one approval. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns, ngraham Cc: meven, kde-frameworks-devel, #baloo,

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson added a comment. > I will try to cook up a more complete solution over the weekend. If you can explain what you would prefer instead, I can help find time. INLINE COMMENTS > bruns wrote in app.cpp:119 > This is a little bit confusing, as the lmdb code uses `rc == LMDB_OK

D25583: Quit baloo_file_extractor if DB transaction fails

bruns added a comment. ... and sorry for the late answer ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns, ngraham Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov,

D25583: Quit baloo_file_extractor if DB transaction fails

bruns added a comment. I will try to cook up a more complete solution over the weekend. INLINE COMMENTS > app.cpp:119 > } else { > -m_tr->commit(); > +bool rc = m_tr->commit(); > delete m_tr; This is a little bit confusing, as the lmdb code uses `rc == LMDB_OK

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson added a comment. One more ping. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns, ngraham Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh,

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson added a comment. Bump. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns, ngraham Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson requested review of this revision. davidedmundson marked 3 inline comments as done. davidedmundson added a comment. > Please allow some time for reviewing ... Marking as request review, so it hopefully reappears in your TODO queue. REPOSITORY R293 Baloo REVISION DETAIL

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson added a comment. Ack, was going to wait for you :) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns, ngraham Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

D25583: Quit baloo_file_extractor if DB transaction fails

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Please allow some time for reviewing ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns, ngraham Cc: meven,

D25583: Quit baloo_file_extractor if DB transaction fails

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns, ngraham Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n,

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson updated this revision to Diff 70488. davidedmundson added a comment. New output: _TXN: Transaction must abort, has a child, or is invalid 12:35:09.167 org.kde.baloo.engine: Baloo::PositionDB::put|Baloo::WriteTransaction::commit|Baloo::Transaction::commit PositionDB::put

D25583: Quit baloo_file_extractor if DB transaction fails

meven added inline comments. INLINE COMMENTS > davidedmundson wrote in app.cpp:145 > There's a tonne in the transaction code Alright but since the program exits here, I am concerned it may not be clear enough to the user/caller as to why it exited ? Adding a log here will add a different

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson added inline comments. INLINE COMMENTS > meven wrote in app.cpp:145 > Add a Warning/log message ? `qCWarning(BALOO) << "Could not save data to DB"` > or similar There's a tonne in the transaction code REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583

D25583: Quit baloo_file_extractor if DB transaction fails

meven added inline comments. INLINE COMMENTS > app.cpp:145 > +} else { > +QCoreApplication::quit(); > +} Add a Warning/log message ? `qCWarning(BALOO) << "Could not save data to DB"` or similar REPOSITORY R293 Baloo REVISION DETAIL

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson added a reviewer: bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Currently I have a broken DB, the worst part is that I'm in a 100% CPU loop.