D25682: [WIP] add initial wsdiscovery support

sitter updated this revision to Diff 73405. sitter marked 19 inline comments as done. sitter added a comment. since there's not been much design input let's move to actual review primary change here is that wsdiscoverer no longer uses qtconcurrent but instead signal slots on the same thr

D25682: [WIP] add initial wsdiscovery support

meven added a comment. A few qDebug not to forget to clean before merging. INLINE COMMENTS > kio_smb_browse.cpp:380 > > + > udsentry.fastInsert( KIO::UDSEntry::UDS_NAME, udsName ); remove > kio_smb_browse.cpp:544 > if (dir_is_root) { > + qDebug() << "dir is r

D25682: [WIP] add initial wsdiscovery support

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > discovery.cpp:31 > +Discoverer::Discoverer() = default; > +Discoverer::~Discoverer() = default; Lines 30-31 duplicate lines 23-28, surely this can't link with

D25682: [WIP] add initial wsdiscovery support

sitter updated this revision to Diff 71121. sitter marked 9 inline comments as done. sitter added a comment. various fixes suggested by dfaure REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25682?vs=70750&id=71121 BRANCH master REVISION DETAIL http

D25682: [WIP] add initial wsdiscovery support

sitter marked 26 inline comments as done. sitter added a comment. Yep, still looking for primarily design input. Thanks for your comments, David! INLINE COMMENTS > dfaure wrote in discovery.h:40 > Why don't these `toEntry()` methods *return* a KIO::UDSEntry instead? > It's always empty o

D25682: [WIP] add initial wsdiscovery support

bcooksley added a comment. With regards to the Docker/Gitlab CI part, please use the images under kdeorg/ on Dockerhub rather than personally maintained images as the wider community has no access to your namespace on Gitlab.com (Additionally please note that Fedora is not permitted to b

D25682: [WIP] add initial wsdiscovery support

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I guess you were expecting a higher-level review, but I don't know anything about these protocols. I'm glad to see my KDSoap library being useful in KDE too though :-) INLINE

D25682: [WIP] add initial wsdiscovery support

ngraham added reviewers: dfaure, Frameworks, Dolphin. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25682 To: sitter, dfaure, #frameworks, #dolphin Cc: ngraham, caspermeijn, davidedmundson, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, Mr

D25682: [WIP] add initial wsdiscovery support

caspermeijn added a comment. In D25682#570849 , @sitter wrote: > In D25682#570845 , @davidedmundson wrote: > > > Why do we need to mirror this dsoap-ws-discovery-client lib that seems to be copied f

D25682: [WIP] add initial wsdiscovery support

ngraham added a comment. OMG it works!!! I can find my windows Samba share in Dolphin again! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25682 To: sitter Cc: ngraham, caspermeijn, davidedmundson, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, L

D25682: [WIP] add initial wsdiscovery support

sitter added a subscriber: caspermeijn. sitter added a comment. In D25682#570845 , @davidedmundson wrote: > Why do we need to mirror this dsoap-ws-discovery-client lib that seems to be copied from somewhere? Testing convenience until @ca

D25682: [WIP] add initial wsdiscovery support

davidedmundson added a comment. Why do we need to mirror this dsoap-ws-discovery-client lib that seems to be copied from somewhere? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25682 To: sitter Cc: davidedmundson, kde-frameworks-devel, kfm-devel, pberestov, ia

D25682: [WIP] add initial wsdiscovery support

ngraham edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25682 To: sitter Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spooru

D25682: [WIP] add initial wsdiscovery support

sitter created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY needs kdsoap >= 1.8.50 (current master). builds a static variant of kdsoap-ws-discovery-client but can