D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf added a comment. In D25699#576444 , @fvogt wrote: > This fixed the button label, but the menu itself is unsuable due to a black text on dark background: https://openqa.opensuse.org/tests/1110939#step/start_wayland_plasma5/21

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

fvogt added a comment. This fixed the button label, but the menu itself is unsuable due to a black text on dark background: https://openqa.opensuse.org/tests/1110939#step/start_wayland_plasma5/21 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf added a comment. Let's track the arrow issue in: https://bugs.kde.org/show_bug.cgi?id=415049 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma, ngraham, davidedmundson Cc: mart, davidedmundson, fvogt,

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

This revision was automatically updated to reflect the committed changes. Closed by commit R242:e4e1613b0fe7: [PC3 ToolButton] Have the label take into account complementary color schemes (authored by filipf). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf edited the summary of this revision. filipf edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH ok-text-colo (branched from master) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma, ngraham, davidedmundson Cc: mart,

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

fvogt added a comment. In D25699#575278 , @davidedmundson wrote: > Please don't link external sites (GitHub) in the committed message. > > RE: Menu > There is nothing in QQC2::Button to add a menu > > If we want that it would have to

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

davidedmundson accepted this revision. davidedmundson added a comment. Please don't link external sites (GitHub) in the committed message. RE: Menu There is nothing in QQC2::Button to add a menu If we want that it would have to be a custom button subclass, rather than something we

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf added subscribers: davidedmundson, mart. filipf added a comment. Yeah, PC2 ToolButton has this so it loads the arrow: https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmastyle/ToolButtonStyle.qml#L110 For PC3 I guess we would have to hack it in in the

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf added a comment. In D25699#573713 , @fvogt wrote: > The check for the prefix was added in `bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc`, while the `control.flat` one got added much earlier. > > The labels are visible again with just the

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

fvogt added a comment. The check for the prefix was added in `bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc`, while the `control.flat` one got added much earlier. The labels are visible again with just the `control.flat` condition, but the prefix one might be needed as well for non-breeze

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH ok-text-colo (branched from master) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH ok-text-colo (branched from master) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma, ngraham Cc: kde-frameworks-devel, LeGast00n,

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf edited the test plan for this revision. filipf added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY We've ported the SDDM theme to PC3 and now have black labels in PC3 ToolButtons (keyboard and session button). The