D25705: Deprecate KIO::pixmapForUrl

nicolasfella abandoned this revision. nicolasfella added a comment. Moved to https://invent.kde.org/frameworks/kio/-/merge_requests/144 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks, dfaure Cc: kossebau, apol, kde-frameworks-devel,

D25705: Deprecate KIO::pixmapForUrl

kossebau added inline comments. INLINE COMMENTS > pixmaploader.h:37 > * > + * @deprecated since 5.70, use KIO::iconNameForUrl() > + * to get the icon name and use QIcon::fromTheme().pixmap() `@deprecated` should go after `@return` here, cmp.

D25705: Deprecate KIO::pixmapForUrl

nicolasfella planned changes to this revision. nicolasfella added a comment. Seems like I missed some usages REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack,

D25705: Deprecate KIO::pixmapForUrl

nicolasfella updated this revision to Diff 80199. nicolasfella added a comment. - Fix update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25705?vs=80197=80199 BRANCH arcpatch-D25705_1 REVISION DETAIL https://phabricator.kde.org/D25705 AFFECTED FILES

D25705: Deprecate KIO::pixmapForUrl

nicolasfella added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25705: Deprecate KIO::pixmapForUrl

nicolasfella updated this revision to Diff 80197. nicolasfella added a comment. - Update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25705?vs=72413=80197 BRANCH arcpatch-D25705_1 REVISION DETAIL https://phabricator.kde.org/D25705 AFFECTED FILES

D25705: Deprecate KIO::pixmapForUrl

nicolasfella updated this revision to Diff 72413. nicolasfella added a comment. - Fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25705?vs=70804=72413 BRANCH arcpatch-D25705 REVISION DETAIL https://phabricator.kde.org/D25705 AFFECTED FILES

D25705: Deprecate KIO::pixmapForUrl

nicolasfella added a comment. In D25705#571458 , @apol wrote: > What do you mean by `Can easily be done otherwise.`? You can get an icon name for the icon with KIO::iconNameForUrl and then use QIcon API if you really need a pixmap

D25705: Deprecate KIO::pixmapForUrl

kossebau added inline comments. INLINE COMMENTS > pixmaploader.h:47 > */ > +#if KIOWIDGETS_ENABLE_DEPRECATED_SINCE(5, 65) > + This line should be before the API dox comment. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks Cc:

D25705: Deprecate KIO::pixmapForUrl

apol added a comment. What do you mean by `Can easily be done otherwise.`? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25705: Deprecate KIO::pixmapForUrl

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Can easily be done otherwise. REPOSITORY R241 KIO BRANCH pfo