D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ee08d0b4e56e: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella added a comment. In D25707#645694 , @dfaure wrote: > OK. Then let me change my comment to: please document in kiconloader.h how to port away from loadMimeTypeIcon, even if it's not actually deprecated. > > I remember wondering

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

dfaure added a comment. OK. Then let me change my comment to: please document in kiconloader.h how to port away from loadMimeTypeIcon, even if it's not actually deprecated. I remember wondering the same thing at one point. REPOSITORY R241 KIO BRANCH rena REVISION DETAIL

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

ahmadsamir added a comment. In D25707#645676 , @dfaure wrote: > loadMimeTypeIcon isn't deprecated, so what's the reason? Porting away from kiconthemes? Should we actually deprecate it? It's been going on for a while

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. loadMimeTypeIcon isn't deprecated, so what's the reason? Porting away from kiconthemes? Should we actually deprecate it? REPOSITORY R241 KIO BRANCH rena REVISION DETAIL

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella added a comment. Well, there are certainly more ugly things out there :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

broulik added a comment. Why is it ugly? I think the fallback is usually meant to fall back to e.g. a built-in icon pixmap, but doing a chain of `fromTheme` fallbacks is just fine imho. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella,

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella added a comment. It's a bit ugly that fallback is a QIcon, not a QString :/ I will send a patch to Qt REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella updated this revision to Diff 70853. nicolasfella added a comment. - Fall back to application-octet-stream REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25707?vs=70806=70853 BRANCH rena REVISION DETAIL https://phabricator.kde.org/D25707

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

broulik added a comment. From what I understood `loadMimeTypeIcon` has this fallback to use "Unknown" icon, see D15451 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks Cc: broulik,

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN Triggered rename dialog. Still have icons in there REPOSITORY R241 KIO