D25727: Expose enum to the metaobject compiler

apol added a comment. Had to revert the commit, it broke with GCC. https://commits.kde.org/kpeople/b495b1a260cd15463a03ee47614b783ae8c2203d REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25727 To: apol, jbbgameich, davidedmundson Cc: dfaure, lnj,

D25727: Expose enum to the metaobject compiler

dfaure added a comment. CI = not happy src/declarative/peopleqmlplugin.cpp:73: undefined reference to `KPeople::staticMetaObject' REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25727 To: apol, jbbgameich, davidedmundson Cc: dfaure, lnj, davidedmundson,

D25727: Expose enum to the metaobject compiler

This revision was automatically updated to reflect the committed changes. Closed by commit R307:508b1bab207e: Expose enum to the metaobject compiler (authored by apol). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25727?vs=70997=71093 REVISION DETAIL

D25727: Expose enum to the metaobject compiler

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH arcpatch-D25727 REVISION DETAIL https://phabricator.kde.org/D25727 To: apol, jbbgameich, davidedmundson Cc: lnj, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2,

D25727: Expose enum to the metaobject compiler

apol updated this revision to Diff 70997. apol added a comment. Alternative approach without Q_NAMESPACE_EXPORT, which is too new REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25727?vs=70895=70997 BRANCH arcpatch-D25727 REVISION DETAIL

D25727: Expose enum to the metaobject compiler

davidedmundson added a comment. Bah, seems Q_NAMESPACE_EXPORT is quite new REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25727 To: apol, jbbgameich Cc: lnj, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25727: Expose enum to the metaobject compiler

apol updated this revision to Diff 70895. apol added a comment. Export the namespace REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25727?vs=70872=70895 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25727 AFFECTED FILES

D25727: Expose enum to the metaobject compiler

lnj added a comment. The ActionsTypes are already registered using a wrapper class (this was required before Qt 5.8 / Q_NAMESPACE) in peopleqmlplugin.cpp. The Q_NAMESPACE solution would be better I think. And yes, the namespace still needs to be registered using e.g.

D25727: Expose enum to the metaobject compiler

davidedmundson added a comment. I thought you need some kind of qmlRegisterType in order to use it? (but if it does work as-is, ship it) REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25727 To: apol, jbbgameich Cc: davidedmundson, kde-frameworks-devel,

D25727: Expose enum to the metaobject compiler

apol created this revision. apol added a reviewer: jbbgameich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Should Help the PersonActionsModel work on QML REPOSITORY R307 KPeople BRANCH master