D25753: EBN extra-cmake-modules transport cleanup

2019-12-06 Thread John Hayes
jhayes added a comment. The two links I know of are: http://0pointer.de/lennart/projects/libcanberra (works as is in file but wont work as https) http://www.x86-64.org/documentation/abi.pdf (http://www.x86-64.org is dead) REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D25753: EBN extra-cmake-modules transport cleanup

2019-12-06 Thread Christophe Giboudeaux
cgiboudeaux added a comment. In D25753#572894 , @winterz wrote: > please send me a list of urls that don't have https: and I'll add them to the whitelist The x86-64.org domain is dead. I'm not sure about what could be used instead.

D25753: EBN extra-cmake-modules transport cleanup

2019-12-05 Thread Allen Winter
winterz added a comment. please send me a list of urls that don't have https: and I'll add them to the whitelist REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25753 To: jhayes, apol, cgiboudeaux Cc: winterz, cgiboudeaux, kde-frameworks-devel,

D25753: EBN extra-cmake-modules transport cleanup

2019-12-05 Thread Christophe Giboudeaux
This revision was automatically updated to reflect the committed changes. Closed by commit R240:f082ed20e6a8: EBN extra-cmake-modules transport cleanup (authored by jhayes, committed by cgiboudeaux). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25753?vs=70973=70986#toc REPOSITORY

D25753: EBN extra-cmake-modules transport cleanup

2019-12-05 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25753 To: jhayes, apol, cgiboudeaux Cc: cgiboudeaux,

D25753: EBN extra-cmake-modules transport cleanup

2019-12-05 Thread John Hayes
jhayes updated this revision to Diff 70973. jhayes added a comment. - Corrected URL as review comments Corrected url to http://www.sphinx-doc.org REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25753?vs=70958=70973 BRANCH

D25753: EBN extra-cmake-modules transport cleanup

2019-12-05 Thread Christophe Giboudeaux
cgiboudeaux added a comment. The sphinx doc URL is https://www.sphinx-doc.org (it just doesn't work without www) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25753 To: jhayes, apol, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem,

D25753: EBN extra-cmake-modules transport cleanup

2019-12-05 Thread John Hayes
jhayes updated this revision to Diff 70958. jhayes added a comment. - Corrections made per review comments. Reverted some non-working URL's back to http and updated one URL to the correct address REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D25753: EBN extra-cmake-modules transport cleanup

2019-12-05 Thread Christophe Giboudeaux
cgiboudeaux added inline comments. INLINE COMMENTS > FindCanberra.cmake:98 > DESCRIPTION "Event sound library" > -URL "http://0pointer.de/lennart/projects/libcanberra; > +URL "https://0pointer.de/lennart/projects/libcanberra; > ) redirects to http://0pointer.net/ which is probably

D25753: EBN extra-cmake-modules transport cleanup

2019-12-05 Thread Christophe Giboudeaux
cgiboudeaux requested changes to this revision. cgiboudeaux added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:35 > PROPERTIES > -URL "http://sphinx-doc.org/; > +URL "https://sphinx-doc.org/; > DESCRIPTION "Tool to

D25753: EBN extra-cmake-modules transport cleanup

2019-12-04 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25753 To: jhayes, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n,

D25753: EBN extra-cmake-modules transport cleanup

2019-12-04 Thread John Hayes
jhayes created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Change transport protocol from http to https REPOSITORY R240 Extra CMake Modules BRANCH