D25897: Add 32, 48 and 64 px user-desktop icons

2019-12-13 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R242:bcc1ba205d60: Add 32, 48 and 64 px user-desktop icons (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25897?vs=71467=71469

D25897: Add 32, 48 and 64 px user-desktop icons

2019-12-13 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH show-desktop-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D25897 To: ndavis, #plasma, #vdg, ngraham Cc: ngraham,

D25897: Add 32, 48 and 64 px user-desktop icons

2019-12-13 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25897 To: ndavis, #plasma, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25897: Add 32, 48 and 64 px user-desktop icons

2019-12-13 Thread Noah Davis
ndavis updated this revision to Diff 71467. ndavis added a comment. - increase line thickness for 48 and 64 px REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25897?vs=71303=71467 BRANCH show-desktop-icon (branched from master)

D25897: Add 32, 48 and 64 px user-desktop icons

2019-12-13 Thread Noah Davis
ndavis added a comment. In D25897#576015 , @ngraham wrote: > The straight lines in the system tray items from my screenshot are definitely 1px strokes. But all the curved lines look thicker by virtue of not being able to align to the pixel

D25897: Add 32, 48 and 64 px user-desktop icons

2019-12-12 Thread Nathaniel Graham
ngraham added a comment. The straight lines in the system tray items from my screenshot are definitely 1px strokes. But all the curved lines look thicker by virtue of not being able to align to the pixel grid. And most monochrome widgets have thicker lines when added to a tall panel:

D25897: Add 32, 48 and 64 px user-desktop icons

2019-12-11 Thread Noah Davis
ndavis added a comment. In D25897#575934 , @ngraham wrote: > Thanks. However I wonder if the stroke width ought to increase for the larger sizes? Having such skinny lines looks a tad odd to me IMO: > > F7813271:

D25897: Add 32, 48 and 64 px user-desktop icons

2019-12-11 Thread Nathaniel Graham
ngraham added a comment. Thanks. However I wonder if the stroke width ought to increase for the larger sizes? Having such skinny lines looks a tad odd to me IMO: F7813271: Screenshot_20191211_235533.png REPOSITORY R242 Plasma Framework (Library)

D25897: Add 32, 48 and 64 px user-desktop icons

2019-12-11 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25897 To: ndavis, #plasma, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25897: Add 32, 48 and 64 px user-desktop icons

2019-12-11 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY This prevents the icon from becoming blurry at fairly normal panel widths. TEST