D25999: Add optional subtitle to grid delegate

broulik added inline comments. INLINE COMMENTS > GridDelegate.qml:81 > height: Kirigami.Settings.isMobile ? Math.round((delegate.width - > Kirigami.Units.gridUnit) / 1.6) > - : > Math.min(delegate.GridView.view.implicitCellHeight - Kirigami.Uni

D25999: Add optional subtitle to grid delegate

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R296:0dda5f9566cf: Add optional subtitle to grid delegate (authored by ngraham). REPOSITORY R296 KDeclarative CHANGES SI

D25999: Add optional subtitle to grid delegate

ngraham added a comment. Got a shipit from @davidedmundson, shippingit! REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundson Cc: ndavis, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25999: Add optional subtitle to grid delegate

ndavis resigned from this revision. ndavis added a comment. This revision now requires review to proceed. Whoops, didn't mean to give my official approval REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundson Cc: ndavis

D25999: Add optional subtitle to grid delegate

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. +1 visually REPOSITORY R296 KDeclarative BRANCH optional-subtitle (branched from master) REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundso

D25999: Add optional subtitle to grid delegate

filipf added a comment. ^ No, it seems to be GridDelegate actually. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundson Cc: filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25999: Add optional subtitle to grid delegate

filipf added a comment. In D25999#577780 , @ngraham wrote: > It does, because we can't know in advance whether or not any delegates will set a subtitle. Actually... can we know this? Yeah if we could it wouldn't be bad to add a condition.

D25999: Add optional subtitle to grid delegate

ngraham updated this revision to Diff 71540. ngraham marked an inline comment as done. ngraham added a comment. Remove pointless check REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25999?vs=71535&id=71540 BRANCH optional-subtitle (branched from mas

D25999: Add optional subtitle to grid delegate

davidedmundson added inline comments. INLINE COMMENTS > GridDelegate.qml:193 > +id: caption > +visible: delegate.subtitle && delegate.subtitle.length > 0 > +opacity: 0.6 what is the first clause for? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.k

D25999: Add optional subtitle to grid delegate

ngraham added a comment. It does, because we can't know in advance whether or not any delegates will set a subtitle. Actually... can we know this? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundson Cc: filipf, kde-f

D25999: Add optional subtitle to grid delegate

filipf added a comment. Thanks, I'll tweak my patch to use this. Does the implementation increase the horizontal spacing between delegates even if there are no subtitles present? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #pla

D25999: Add optional subtitle to grid delegate

filipf added a dependent revision: D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundson Cc: kde-frameworks-devel, LeGa

D25999: Add optional subtitle to grid delegate

ngraham edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25999: Add optional subtitle to grid delegate

ngraham created this revision. ngraham added reviewers: VDG, Plasma, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY In various cases, we may want some or all grid delegates to have a