GB_2 updated this revision to Diff 73195.
GB_2 marked an inline comment as done.
GB_2 added a comment.
Use David's suggestion
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26043?vs=71675&id=73195
BRANCH
arcpatch-D26043
REVISION DETAI
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:629db2f3b55b: Add edit mode menu item to desktop widget
context menu (authored by GB_2).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26043?vs=
davidedmundson accepted this revision.
davidedmundson added inline comments.
INLINE COMMENTS
> containmentinterface.cpp:1129
> +if (m_containment->containmentType() ==
> Plasma::Types::DesktopContainment) {
> +
> desktopMenu->addAction(m_containment->corona()->actions()->action(QStri
GB_2 added a comment.
Ping :-)
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26043
To: GB_2, #plasma, #vdg, mart, ngraham
Cc: ngraham, broulik, mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n,
GB_2, michaelh, bruns
ngraham accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26043
To: GB_2, #plasma, #vdg, mart, ngraham
Cc: ngraham, broulik, mart, #vdg, kde-frameworks-devel, #plas
GB_2 added a comment.
Ping.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D26043
To: GB_2, #plasma, #vdg, mart
Cc: ngraham, broulik, mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n,
GB_2, michaelh, bruns
ngraham added a comment.
+1, makes sense
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D26043
To: GB_2, #plasma, #vdg, mart
Cc: ngraham, broulik, mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n,
GB_2, michaelh, bruns
GB_2 added inline comments.
INLINE COMMENTS
> broulik wrote in containmentinterface.cpp:1128
> Please check `m_containment->immutability()` so we don't add this if widgets
> are locked
Are you sure? It is already automatically disabled when immutability is
`UserImmutable` and completely hidden
broulik added inline comments.
INLINE COMMENTS
> containmentinterface.cpp:1128
> +desktopMenu->addSeparator();
> +if (m_containment->containmentType() ==
> Plasma::Types::DesktopContainment) {
> +
> desktopMenu->addAction(m_containment->corona()->actions()->action(QStringLiteral(
GB_2 updated this revision to Diff 71675.
GB_2 added a comment.
Remove space
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26043?vs=71674&id=71675
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26043
AFFECTED FILES
s
GB_2 updated this revision to Diff 71674.
GB_2 added a comment.
Decrease line count
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26043?vs=71670&id=71674
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26043
AFFECTED FI
GB_2 added a reviewer: mart.
GB_2 added a subscriber: mart.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D26043
To: GB_2, #plasma, #vdg, mart
Cc: mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh,
ngraham, bruns
GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.
REVISION SUMMARY
- much improves discoverability of the ability to move added widgets without
clicking and
GB_2 edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D26043
To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham,
bruns
14 matches
Mail list logo
