D26113: Places: Use Solid::Device::DisplayName for DisplayRole

meven closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #frameworks, ngraham, dfaure Cc: dfaure, feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R241 KIO BRANCH arcpatch-D26113 REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #frameworks, ngraham, dfaure Cc: dfaure, feverfew, bruns, broulik, k

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

meven added a comment. In D26113#674129 , @dfaure wrote: > Please check that kfileplacesmodeltest and kfileplacesviewtest still pass. Just did, nothing changed, it is expected : only fstab declared filesystem or manually mounted fs displa

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

dfaure added a comment. Please check that kfileplacesmodeltest and kfileplacesviewtest still pass. (they fail here with baloosearch: stuff for some reason, I didn't investigate; but it passes on CI) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #frameworks, ngraham Cc: dfaure, feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

meven added a subscriber: dfaure. meven added a comment. This should be ready to land @dfaure @ngraham (D26114 will land after KF 5.71 release) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #frameworks, ngraham

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

meven updated this revision to Diff 83162. meven added a comment. Update to new Solid::Device::DisplayName REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26113?vs=79277&id=83162 BRANCH arcpatch-D26113 REVISION DETAIL https://phabricator.kde.org/D26113 AF

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

meven retitled this revision from "Places: For mounted volume display mount points instead of description" to "Places: Use Solid::Device::DisplayName for DisplayRole". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #frameworks, ngraham Cc: feverfew, bruns