D26129: Remove Iterator based loops for range based loops

tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26129 To: tcanabrava, ervin Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26129: Remove Iterator based loops for range based loops

ervin added a comment. In D26129#582392 , @tcanabrava wrote: > I didn't blindly change anything, everything I did I tested either by running the unittests or recompilling and testing the settings of applications. Sure I know you did this

D26129: Remove Iterator based loops for range based loops

tcanabrava added inline comments. INLINE COMMENTS > ervin wrote in kconfig_compiler.cpp:2119 > This logic is very flawed... instead of comparing positions in the list now > you're comparing actual values. If two different positions in the list would > end up having the same values (for some rea

D26129: Remove Iterator based loops for range based loops

tcanabrava added a comment. In D26129#582336 , @ervin wrote: > The patch being large I didn't check each one separately but I suspect this patch misses boat loads of qAsConst. Yes, it indeed misses, I'll add the qAsConst. ( I would actual

D26129: Remove Iterator based loops for range based loops

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. The patch being large I didn't check each one separately but I suspect this patch misses boat loads of qAsConst. Besides there's at least one case of very flawed logic, it can't be

D26129: Remove Iterator based loops for range based loops

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. TEST PLAN Compiled and run the unittests REPOSITORY R237 KConfig BRANCH rangeBasedFor REVISION DETAIL https://phabricator.