This revision was automatically updated to reflect the committed changes.
ahmadsamir marked an inline comment as done.
Closed by commit R238:36fae9517502: [KDocTools] Port QRegExp to
QRegularExpression (authored by ahmadsamir).
REPOSITORY
R238 KDocTools
CHANGES SINCE LAST UPDATE
apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> ahmadsamir wrote in docbookl10nhelper.cpp:184
> I did it that way to indicate match is going to be re-assigned-to later on,
> but it does look off a bit. :)
The way of
ahmadsamir marked 2 inline comments as done.
ahmadsamir added inline comments.
INLINE COMMENTS
> apol wrote in docbookl10nhelper.cpp:184
> Just do `QRegularExpressionMatch match = rxEntity.match(line);`
I did it that way to indicate match is going to be re-assigned-to later on, but
it does
ahmadsamir updated this revision to Diff 72037.
ahmadsamir added a comment.
Make QRegularExpression objects const.
Declare and assign on one line.
REPOSITORY
R238 KDocTools
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26156?vs=72004=72037
BRANCH
l-qregularexpression
apol added a comment.
LGTM otherwise
INLINE COMMENTS
> docbookl10nhelper.cpp:158
> **/
> -QRegExp rxEntity, rxEntity2, rxDocType, rxDocType2;
> -
> rxDocType.setPattern(QStringLiteral("^\\s* -
> rxDocType2.setPattern(QStringLiteral("^\\s*$"));
> -
>
ahmadsamir created this revision.
ahmadsamir added reviewers: Documentation, ltoscano.
Herald added projects: Frameworks, Documentation.
ahmadsamir requested review of this revision.
REVISION SUMMARY
xslt.cpp didn't really use QRegExp as the line using it has been commented
out since 2013,
