D26440: Add utility method for opening a KSharedConfig suitable to store state information

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Looks good. I'm just going back and forth in my mind between dolphinstate and dolphinstaterc. The latter would have the benefit of telling experienced developers that it uses the KConfig fi

D26440: Add utility method for opening a KSharedConfig suitable to store state information

nicolasfella added inline comments. INLINE COMMENTS > dfaure wrote in ksharedconfig.cpp:124 > My idea was to add `const QString &fileName = QString()` to this method so > that complex apps can use multiple state files. Or for parts and plugins to > use a fixed name whatever app they're in. > (o

D26440: Add utility method for opening a KSharedConfig suitable to store state information

nicolasfella updated this revision to Diff 72820. nicolasfella marked an inline comment as done. nicolasfella added a comment. - Add filename arg and use simpleconfig REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26440?vs=72818&id=72820 BRANCH state RE

D26440: Add utility method for opening a KSharedConfig suitable to store state information

nicolasfella added a comment. In D26440#588110 , @dfaure wrote: > > For e.g. dolphin the file .config/dolphin/dolphinstate would be created. > > You mean ~/.local/share/dolphin/dolphinstate, right? Of course REPOSITORY R237 KConfig

D26440: Add utility method for opening a KSharedConfig suitable to store state information

nicolasfella edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26440 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26440: Add utility method for opening a KSharedConfig suitable to store state information

dfaure added a comment. > For e.g. dolphin the file .config/dolphin/dolphinstate would be created. You mean ~/.local/share/dolphin/dolphinstate, right? INLINE COMMENTS > ksharedconfig.cpp:124 > > +KSharedConfig::Ptr KSharedConfig::openStateConfig() > +{ My idea was to add `const QStri

D26440: Add utility method for opening a KSharedConfig suitable to store state information

nicolasfella edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26440 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26440: Add utility method for opening a KSharedConfig suitable to store state information

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY A common complaint is that our apps store 'state' informatio