This revision was automatically updated to reflect the committed changes.
Closed by commit R278:493452e98f99: Introduce shadows API (authored by zzag).
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26457?vs=74055&id=74060
REVISION DETAIL
https://phabr
zzag updated this revision to Diff 74055.
zzag added a comment.
Set padding of 1 for missing borders
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26457?vs=73733&id=74055
BRANCH
kwindowshadow
REVISION DETAIL
https://phabricator.kde.org/D26457
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Good stuff!
INLINE COMMENTS
> kwindowshadow_p_x11.h:45
> +
> +KWindowShadowTile::Ptr emptyTile;
> +};
We typically have an m_ prefix for member variables
*3
REPOSITOR
zzag updated this revision to Diff 73733.
zzag added a comment.
Update doc.
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26457?vs=73728&id=73733
BRANCH
kwindowshadow
REVISION DETAIL
https://phabricator.kde.org/D26457
AFFECTED FILES
src/CMak
zzag updated this revision to Diff 73728.
zzag added a comment.
No `noexcept`
`noexcept` is a very rare thing to see in KF code so let's not deviate too
much.
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26457?vs=73352&id=73728
BRANCH
kwind
zzag retitled this revision from "Introduce shadow API" to "Introduce shadows
API".
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D26457
To: zzag, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
