D26540: Consistency: colored selected buttons

mart added a comment. In D26540#590924 , @davidedmundson wrote: > Can you update tests/components/button.qml tests/components/button3.qml > > just a button with "focus: true" and some label that says "this should be highlighted on load"

D26540: Consistency: colored selected buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1d6870b15624: Consistency: colored selected buttons (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26540?vs=73122=73138

D26540: Consistency: colored selected buttons

davidedmundson added a comment. Can you update tests/components/button.qml tests/components/button3.qml just a button with "focus: true" and some label that says "this should be highlighted on load" REPOSITORY R242 Plasma Framework (Library) BRANCH phab/bluebutton REVISION

D26540: Consistency: colored selected buttons

mart added a comment. In D26540#590892 , @ngraham wrote: > +1 for consistency, definitely. One thing to note maybe for a future patch is that the focus behaviors is still a bit inconsistent with the desktop style: Clicking on a button doesn't

D26540: Consistency: colored selected buttons

ngraham added a reviewer: Goal: Consistency. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 for consistency, definitely. One thing to note maybe for a future patch is that the focus behaviors is still a bit inconsistent with the

D26540: Consistency: colored selected buttons

mart edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26540 To: mart, #plasma, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26540: Consistency: colored selected buttons

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY color selected buttons to the highlight color when it has keyboard focus. This makes