D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

This revision was automatically updated to reflect the committed changes. Closed by commit R304:198e589d5df5: Unbreak the KNSQuick::Engine::changedEntries functionality (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir updated this revision to Diff 73698. leinir added a comment. Some housekeeping (rebase on master) - Actually update the entry when it's updated, don't just ignore it - As 5.66 was released, update @since to 5.67 - Actually use the correct type for the list property REPOSITORY

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir added a comment. In D26543#595374 , @davidedmundson wrote: > Given timeframes and where we've ended up. Accepted. Thanks! :) > I would like to see some KF6 workboard tasks for the future. That would be a good idea, yup.

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Given timeframes and where we've ended up. Accepted. I would like to see some KF6 workboard tasks for the future. QVariantList + QGadget should work, though that does

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir added a comment. In D26543#595368 , @davidedmundson wrote: > I've gone through this again, and I'm somewhat confused. > Entry (via EntryWrapper) doesn't seem usable by QML. It doesn't have any properties. > > If it's just proxying

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

davidedmundson added a comment. I've gone through this again, and I'm somewhat confused. Entry (via EntryWrapper) doesn't seem usable by QML. It doesn't have any properties. If it's just proxying through QML to other C++, then QVariant should be fine, no need for a custom box type no

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir added a comment. Thanks to David for making me look at that again, the original choice was based on a false-positive test INLINE COMMENTS > davidedmundson wrote in quickengine.h:54 > Why QObject here? > > One of the main advantages of using QQmlListProperty over QList is > that you

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir updated this revision to Diff 73680. leinir marked an inline comment as done. leinir added a comment. - Actually use the correct type for the list property REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26543?vs=73408=73680 BRANCH

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

davidedmundson added inline comments. INLINE COMMENTS > quickengine.h:54 > Q_PROPERTY(QString searchTerm READ searchTerm WRITE setSearchTerm RESET > resetSearchTerm NOTIFY searchTermChanged) > -Q_PROPERTY(KNSCore::EntryInternal::List changedEntries READ > changedEntries RESET

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir updated this revision to Diff 73408. leinir added a comment. - As 5.66 was released, update @since to 5.67 - CMakeLists version requirement fun (for easier testing) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26543?vs=73187=73408 BRANCH

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir updated this revision to Diff 73187. leinir added a comment. - Actually update the entry when it's updated, don't just ignore it REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26543?vs=73126=73187 BRANCH unbreak-changedentries-in-qtquick

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir added a dependent revision: D26544: [WIP] Switch the Plasma Desktop KCMs to using KNewStuffQuick. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D26543 To: leinir, #frameworks, #plasma, ngraham, broulik, mart Cc: kde-frameworks-devel, LeGast00n, GB_2,

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir added reviewers: Frameworks, Plasma, ngraham, broulik, mart. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D26543 To: leinir, #frameworks, #plasma, ngraham, broulik, mart Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This patch changes the previous naive approach to a more elaborate, QQmlListProperty based one. It further introduces a