SGOrava added a comment.
it would, but I am not such great guru.
I tried few ways to change the behaviour but it was even worse,
and since this is used in many programs I do not want to break them.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D26755
To:
dhaumann added a comment.
Well, it definitely would be very nice if you find a patch that fixes this.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D26755
To: SGOrava, #frameworks
Cc: anthonyfieroni, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh,
SGOrava added a comment.
This is the test I used to check the validity of my change, it kind of always
fails.
I only hope someone can fix this widget at least for KF6.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D26755
To: SGOrava, #frameworks
Cc: anthon
SGOrava updated this revision to Diff 73872.
SGOrava added a comment.
- KMessageWidget: Add resize autotest
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26755?vs=73845&id=73872
BRANCH
more-proper-height (branched from master)
REVISION DETAIL
SGOrava added a comment.
It looks good.
But I wrote a test as you suggested which still fails.
The test creates parent widget and puts the kmesagewidget and qlistwidget in
it in vertical order (as in my test app)
and than it resizes the parent widget and compares the height (the availabl
dhaumann resigned from this revision.
dhaumann added a comment.
This revision now requires review to proceed.
In that case I withdraw my review for now. I can only speak for Kate that I
could not find a regression with my tests. But if you find other regressions,
then this is likely not corre
anthonyfieroni added a comment.
That's same issue when file is open then externally modified then updated by
kmessagewidget button cause a frame to not resize correct?
REPOSITORY
R236 KWidgetsAddons
BRANCH
more-proper-height (branched from master)
REVISION DETAIL
https://phabricator.k
SGOrava retitled this revision from "KMessageWidget: Set widget height on
resize event" to "[WIP] KMessageWidget: Set widget height on resize event".
REPOSITORY
R236 KWidgetsAddons
BRANCH
more-proper-height (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26755
To: SGO
