D26931: Introduce SPDX license headers

2020-02-01 Thread Andreas Cord-Landwehr
cordlandwehr added inline comments. INLINE COMMENTS > kossebau wrote in MIT.txt:1 > Does the " " work here? The statement is correct, it directly comes from the SPDX license text registry and is installed via the "reuse download" tool to ensure that the original header is deployed.

D26931: Introduce SPDX license headers

2020-02-01 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > MIT.txt:1 > +MIT License Copyright (c) > + Does the " " work here? REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D26931 To: cordlandwehr, cgiboudeaux Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n,

D26931: Introduce SPDX license headers

2020-02-01 Thread Andreas Cord-Landwehr
This revision was automatically updated to reflect the committed changes. Closed by commit R274:11f5cd0390e4: Introduce SPDX license headers (authored by cordlandwehr). REPOSITORY R274 KIdleTime CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26931?vs=74768=74834 REVISION DETAIL

D26931: Introduce SPDX license headers

2020-01-31 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R274 KIdleTime BRANCH master REVISION DETAIL https://phabricator.kde.org/D26931 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26931: Introduce SPDX license headers

2020-01-31 Thread Andreas Cord-Landwehr
cordlandwehr updated this revision to Diff 74768. cordlandwehr added a comment. Unify copyright header format REPOSITORY R274 KIdleTime CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26931?vs=74452=74768 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26931

D26931: Introduce SPDX license headers

2020-01-27 Thread Christophe Giboudeaux
cgiboudeaux added a comment. In D26931#601508 , @cgiboudeaux wrote: > In D26931#601505 , @cordlandwehr wrote: > > > Convert to SPDX-FileCopyrightText tags > > > some files have by , can I

D26931: Introduce SPDX license headers

2020-01-27 Thread Christophe Giboudeaux
cgiboudeaux added a comment. In D26931#601505 , @cordlandwehr wrote: > Convert to SPDX-FileCopyrightText tags some files have by , can I suggest removing this "by"? REPOSITORY R274 KIdleTime REVISION DETAIL

D26931: Introduce SPDX license headers

2020-01-27 Thread Andreas Cord-Landwehr
cordlandwehr updated this revision to Diff 74452. cordlandwehr added a comment. Convert to SPDX-FileCopyrightText tags REPOSITORY R274 KIdleTime CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26931?vs=74400=74452 BRANCH master REVISION DETAIL

D26931: Introduce SPDX license headers

2020-01-26 Thread Christophe Giboudeaux
cgiboudeaux added a comment. LGTM REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D26931 To: cordlandwehr Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26931: Introduce SPDX license headers

2020-01-26 Thread Andreas Cord-Landwehr
cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D26931 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26931: Introduce SPDX license headers

2020-01-26 Thread Andreas Cord-Landwehr
cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REPOSITORY R274 KIdleTime BRANCH master REVISION DETAIL https://phabricator.kde.org/D26931 AFFECTED FILES