This revision was automatically updated to reflect the committed changes.
Closed by commit R274:5b6d26cd758c: Port away from QWidget (authored by
broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D27279?vs=75345=77252#toc
REPOSITORY
R274 KIdleTime
CHANGES SINCE LAST UPDATE
alnikiforov added a comment.
I think I found source of infinite recursion.
First call is on
https://phabricator.kde.org/source/powerdevil/browse/master/daemon/powerdevilcore.cpp$821
Second call is on
alnikiforov added a comment.
I've managed to reproduce it and take a backtrace. It's an infinite
recursion. Eventually stack's end is reached, although it takes some time to do
it. Here's a piece of backtrace I got:
#460 0x764dcbec in KIdleTimePrivate::_k_resumingFromIdle
broulik added a comment.
> How can I reproduce crash in resume on idle?
For me I set screen turn off to 1 minute, waited for the screen to fade to
black, waited a bit more, got curious why it didn't actually turn it off,
wiggled the mouse, and then found it crashed.
You might need to
alnikiforov added a comment.
I've tested this patch in it's current form, and powerdevil no longer crashes
for me on launch too. How can I reproduce crash in resume on idle? Can it be
done in virtual machine?
REPOSITORY
R274 KIdleTime
REVISION DETAIL
https://phabricator.kde.org/D27279
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R274 KIdleTime
REVISION DETAIL
https://phabricator.kde.org/D27279
To: broulik, #frameworks, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,
broulik added inline comments.
INLINE COMMENTS
> davidedmundson wrote in widgetbasedpoller.h:18
> it's not an installed header, no need to wait
Ok, I'll remove this comment. Let's do the rename in a separate patch when this
goes in.
REPOSITORY
R274 KIdleTime
REVISION DETAIL
davidedmundson added inline comments.
INLINE COMMENTS
> widgetbasedpoller.h:18
>
> +// TODO KF6 rename WindowBasedPoller
> class KIDLETIME_EXPORT WidgetBasedPoller : public AbstractSystemPoller
it's not an installed header, no need to wait
REPOSITORY
R274 KIdleTime
REVISION DETAIL
broulik created this revision.
broulik added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
We can do everything we need with `QWindow`
TEST PLAN
Alternative to D27276
