D27291: install smb as both smb:// and cifs://

This revision was automatically updated to reflect the committed changes. Closed by commit R320:a5f51238fab7: smb: install smb as both smb:// and cifs:// (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27291?vs=75382&id=75603 REVISION

D27291: install smb as both smb:// and cifs://

sitter added a comment. Easy merge for master, just needs some ctrl-c magic. Thanks for the heads up though :) REPOSITORY R320 KIO Extras BRANCH bug327295 REVISION DETAIL https://phabricator.kde.org/D27291 To: sitter, dfaure, ngraham Cc: meven, feverfew, kde-frameworks-devel, kfm-dev

D27291: install smb as both smb:// and cifs://

meven added a comment. Samba protocol has been partly ported to the json format https://phabricator.kde.org/D26358 This may be a great time to add the cifs protocol to `smb/smb.json` instead of propagating another .protocol file REPOSITORY R320 KIO Extras BRANCH bug327295 REVISION DE

D27291: install smb as both smb:// and cifs://

feverfew added a comment. In D27291#609358 , @dfaure wrote: > feverfew: you're probably looking at master while this is a patch for the 19.12 branch. > See https://phabricator.kde.org/D26358 which happened in master. > > I guess that makes

D27291: install smb as both smb:// and cifs://

dfaure added a comment. feverfew: you're probably looking at master while this is a patch for the 19.12 branch. See https://phabricator.kde.org/D26358 which happened in master. I guess that makes this commit ok for 19.12, but it has to be redone differently in master. REPOSITORY R32

D27291: install smb as both smb:// and cifs://

dfaure added a comment. Both are supported, but indeed json is preferred over installed .protocol files. You can use protocoltojson (from kio) to do the conversion. This is all technically unrelated to this commit, except that the nice cmake hack to generate two files isn't even needed

D27291: install smb as both smb:// and cifs://

feverfew added a comment. I'm a bit confused here, isn't the protocol file now a JSON file? I'm looking at the repo and it appears to be the case, so I'm not seeing how this diff is seeing this as a rename? REPOSITORY R320 KIO Extras BRANCH bug327295 REVISION DETAIL https://phabricat

D27291: install smb as both smb:// and cifs://

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH bug327295 REVISION DETAIL https://phabricator.kde.org/D27291 To: sitter, dfaure, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack,

D27291: install smb as both smb:// and cifs://

sitter created this revision. sitter added a reviewer: dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the latter while not IANA registered is apparently used in places. to