D27352: retain atime properly

2020-02-13 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:7f47119b22d5: smb: retain atime properly (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27352?vs=75558&id=75597 REVISION DETAIL https://

D27352: retain atime properly

2020-02-13 Thread Harald Sitter
sitter added a comment. Oh I'm sorry, I thought this was the other time diff. In this case before the accessed time before the patch was flat out garbage https://bugsfiles.kde.org/attachment.cgi?id=121948 note the year **2106** REPOSITORY R320 KIO Extras BRANCH bug410624 REVISION D

D27352: retain atime properly

2020-02-12 Thread Harald Sitter
sitter added a comment. I think I tried with moving. Currently not at home to check. REPOSITORY R320 KIO Extras BRANCH bug410624 REVISION DETAIL https://phabricator.kde.org/D27352 To: sitter, ngraham, meven Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,

D27352: retain atime properly

2020-02-12 Thread Nathaniel Graham
ngraham added a comment. The modified time changes too. Am I testing this right? F8100051: vokoscreenNG-2020-02-12_11-52-33.mp4 REPOSITORY R320 KIO Extras BRANCH bug410624 REVISION DETAIL https://phabricator.kde.org/D27352 To: sitter, ngrah

D27352: retain atime properly

2020-02-12 Thread Harald Sitter
sitter added a comment. No, the access time is always the current time, the modified time should not change. REPOSITORY R320 KIO Extras BRANCH bug410624 REVISION DETAIL https://phabricator.kde.org/D27352 To: sitter, ngraham, meven Cc: kde-frameworks-devel, kfm-devel, pberestov, iasen

D27352: retain atime properly

2020-02-12 Thread Nathaniel Graham
ngraham added a comment. So when I copy a file from my samba share to my desktop, the accessed time of the copied file on my machine should match the accessed time of the version on the server? If so, it doesn't seem to work for me; the accessed time is reset to the time when the file was co

D27352: retain atime properly

2020-02-12 Thread Méven Car
meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH bug410624 REVISION DETAIL https://phabricator.kde.org/D27352 To: sitter, ngraham, meven Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, Mr

D27352: retain atime properly

2020-02-12 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY this was broken since forever I guess. when the .part resume tech was