D27363: KHolidays: Convert license statements to SPDX expressions

This revision was automatically updated to reflect the committed changes. Closed by commit R175:1bc908a8cfea: KHolidays: Convert license statements to SPDX expressions (authored by cordlandwehr). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE

D27363: KHolidays: Convert license statements to SPDX expressions

winterz accepted this revision. This revision is now accepted and ready to land. REPOSITORY R175 KHolidays BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27363 To: cordlandwehr, winterz Cc: cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr marked 3 inline comments as done. cordlandwehr added a comment. Did additional code digging in the Plan repository and I think that all stated copyright claims are valid. INLINE COMMENTS > cgiboudeaux wrote in holidayparserdriverplan.cpp:6-13 > The original text lacks clarity.

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr marked 2 inline comments as done. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27363 To: cordlandwehr Cc: cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr updated this revision to Diff 76151. cordlandwehr marked 2 inline comments as done. cordlandwehr added a comment. Add missing SPDX identifier REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27363?vs=75737=76151 BRANCH spdx REVISION DETAIL

D27363: KHolidays: Convert license statements to SPDX expressions

winterz added a comment. looks ok to me. INLINE COMMENTS > cgiboudeaux wrote in lunarphase.cpp:6 > This looks suspicious > > @winterz ? no, it's fine. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27363 To: cordlandwehr Cc: cgiboudeaux, winterz,

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr updated this revision to Diff 75737. cordlandwehr marked 2 inline comments as done. cordlandwehr added a comment. Make snippet copyright statement more verbose REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27363?vs=75736=75737 BRANCH

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr marked 5 inline comments as done. cordlandwehr added a comment. Updated several statements, but still need clarification if named people are copyright holders or contributors without copyright claim. INLINE COMMENTS > cgiboudeaux wrote in holidayscannerplan.cpp:1297-1301 > and

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr updated this revision to Diff 75736. cordlandwehr added a comment. Clarified several statements - Recovered origin of weekNumber method and its original license - Unified verbose license statements - Clarified snippet licensing REPOSITORY R175 KHolidays CHANGES SINCE

D27363: KHolidays: Convert license statements to SPDX expressions

cgiboudeaux added subscribers: winterz, cgiboudeaux. cgiboudeaux added inline comments. INLINE COMMENTS > holidayregion.cpp:31 > // Copied from qlocale_data_p.h and qlocale.h > -// Copyright (C) 2014 Digia Plc and/or its subsidiary(-ies). > +// SPDX-FileCopyrightText: 2014 Digia Plc and /or its

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27363 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX markers and add license files as required by REUSE specification.