This revision was automatically updated to reflect the committed changes.
Closed by commit R241:6327a9f05eb2: FileWidgets: Ignore Return events from
KDirOperator (authored by meven).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27455?vs=79039=79265
REVISION
dfaure accepted this revision.
REPOSITORY
R241 KIO
BRANCH
arcpatch-D27455
REVISION DETAIL
https://phabricator.kde.org/D27455
To: meven, dfaure, ngraham, #frameworks
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,
ngraham, bruns
meven updated this revision to Diff 79039.
meven added a comment.
Use a single if statement, handle for Qt::Key_Enter as well
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27455?vs=78142=79039
BRANCH
arcpatch-D27455
REVISION DETAIL
ahmadsamir added a comment.
I tested this diff, and it seemed to work as expected.
REPOSITORY
R241 KIO
BRANCH
arcpatch-D27455
REVISION DETAIL
https://phabricator.kde.org/D27455
To: meven, dfaure, ngraham, #frameworks
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2,
ahmadsamir added inline comments.
INLINE COMMENTS
> kfilewidget.cpp:1913
> +} else if (watched == d->ops && event->type() == QEvent::KeyPress) {
> +if (keyEvent->key() == Qt::Key_Return) {
> +// ignore return events from the KDirOperator
I would combine the two if's
meven added a comment.
I did some secondary review.
I'd like to add a test.
REPOSITORY
R241 KIO
BRANCH
arcpatch-D27455
REVISION DETAIL
https://phabricator.kde.org/D27455
To: meven, dfaure, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,
meven updated this revision to Diff 78142.
meven added a comment.
Add event->accept()
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27455?vs=75822=78142
BRANCH
arcpatch-D27455
REVISION DETAIL
https://phabricator.kde.org/D27455
AFFECTED FILES
meven added a comment.
Well I meant to do some checking, despite this works, it does not look nice.
Adding a test would be nice too.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27455
To: meven, dfaure, ngraham, #frameworks
Cc:
ngraham added a comment.
Ping
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27455
To: meven, dfaure, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
cfeck edited the summary of this revision.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27455
To: meven, dfaure, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Nice, works for me.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27455
To: meven, dfaure, ngraham, #frameworks
Cc: kde-frameworks-devel,
meven edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D27455
To: meven, dfaure, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
meven edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D27455
To: meven, dfaure, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
meven added a reviewer: Frameworks.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D27455
To: meven, dfaure, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
meven created this revision.
meven added reviewers: dfaure, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.
REVISION SUMMARY
Activated event is used to handle key returns from KDirOperator.
Making a Return
15 matches
Mail list logo
